Merge pull request #62 from browserstack/chore/green-unit-tests

test: fix pre-existing unit-test failures (green the suite)

Author: 07souravkunda

BrowserStackLocal/BrowserStackLocal Unit Tests/BrowserStackTunnelTests.cs

@@ -192,6 +192,13 @@ private static bool IsExecutable(string path)
     public class TunnelClass : BrowserStackTunnel
     {
       public TunnelClass() : base("test-user-agent") {}
+      // Stub the network boundary so these binary-path/fallback unit tests exercise
+      // the real path-resolution logic without making a live HTTP call to the
+      // endpoint API (which addBinaryPath triggers on first invocation).
+      protected override string fetchSourceUrl(string accessKey)
+      {
+        return null;
+      }
       public StringBuilder getOutputBuilder()
       {
         return output;

BrowserStackLocal/BrowserStackLocal Unit Tests/LocalTests.cs

@@ -110,7 +110,7 @@ public void TestWorksForBinaryPath()
       tunnelMock.Setup(mock => mock.Run("dummyKey", "", logAbsolute, "start"));
       local.setTunnel(tunnelMock.Object);
       local.start(options);
-      tunnelMock.Verify(mock => mock.addBinaryPath("dummyPath", "", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
+      tunnelMock.Verify(mock => mock.addBinaryPath("dummyPath", "dummyKey", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
       tunnelMock.Verify(mock => mock.addBinaryArguments(It.Is<List<string>>(a =>
         InOrder(a, "-logFile", logAbsolute))), Times.Once());
       tunnelMock.Verify(mock => mock.Run("dummyKey", "", logAbsolute, "start"), Times.Once());
@@ -133,7 +133,7 @@ public void TestWorksWithBooleanOptions()
       tunnelMock.Setup(mock => mock.Run("dummyKey", "", logAbsolute, "start"));
       local.setTunnel(tunnelMock.Object);
       local.start(options);
-      tunnelMock.Verify(mock => mock.addBinaryPath("", "", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
+      tunnelMock.Verify(mock => mock.addBinaryPath("", "dummyKey", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
       tunnelMock.Verify(mock => mock.addBinaryArguments(It.Is<List<string>>(a =>
         InOrder(a, "-vvv", "-force", "-forcelocal", "-forceproxy", "-onlyAutomate"))), Times.Once());
       tunnelMock.Verify(mock => mock.Run("dummyKey", "", logAbsolute, "start"), Times.Once());
@@ -157,7 +157,7 @@ public void TestWorksWithValueOptions()
       tunnelMock.Setup(mock =>mock.Run("dummyKey", "", logAbsolute, "start"));
       local.setTunnel(tunnelMock.Object);
       local.start(options);
-      tunnelMock.Verify(mock => mock.addBinaryPath("", "", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
+      tunnelMock.Verify(mock => mock.addBinaryPath("", "dummyKey", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
       tunnelMock.Verify(mock => mock.addBinaryArguments(It.Is<List<string>>(a =>
         InOrder(a, "-localIdentifier", "dummyIdentifier", "dummyHost", "-proxyHost", "dummyHost",
                    "-proxyPort", "dummyPort", "-proxyUser", "dummyUser", "-proxyPass", "dummyPass"))
@@ -181,7 +181,7 @@ public void TestWorksWithCustomOptions()
       tunnelMock.Setup(mock => mock.Run("dummyKey", "", logAbsolute, "start"));
       local.setTunnel(tunnelMock.Object);
       local.start(options);
-      tunnelMock.Verify(mock => mock.addBinaryPath("", "", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
+      tunnelMock.Verify(mock => mock.addBinaryPath("", "dummyKey", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
       tunnelMock.Verify(mock => mock.addBinaryArguments(It.Is<List<string>>(a =>
         InOrder(a, "-customBoolKey1", "-customBoolKey2", "-customKey1", "customValue1",
                    "-customKey2", "customValue2"))
@@ -207,7 +207,7 @@ public void TestCallsFallbackOnFailure()
       });
       local.setTunnel(tunnelMock.Object);
       local.start(options);
-      tunnelMock.Verify(mock => mock.addBinaryPath("", "", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
+      tunnelMock.Verify(mock => mock.addBinaryPath("", "dummyKey", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
       tunnelMock.Verify(mock => mock.addBinaryArguments(It.Is<List<string>>(a =>
         InOrder(a, "-logFile", logAbsolute))), Times.Once());
       tunnelMock.Verify(mock => mock.Run("dummyKey", "", logAbsolute, "start"), Times.Exactly(2));
@@ -227,7 +227,7 @@ public void TestKillsTunnel()
       local.setTunnel(tunnelMock.Object);
       local.start(options);
       local.stop();
-      tunnelMock.Verify(mock => mock.addBinaryPath("", "", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
+      tunnelMock.Verify(mock => mock.addBinaryPath("", "dummyKey", It.IsAny<bool>(), It.IsAny<Exception>()), Times.Once);
       tunnelMock.Verify(mock => mock.addBinaryArguments(It.Is<List<string>>(a =>
         InOrder(a, "-logFile", logAbsolute))), Times.Once());
       tunnelMock.Verify(mock => mock.Run("dummyKey", "", logAbsolute, "start"), Times.Once());

BrowserStackLocal/BrowserStackLocal/BrowserStackTunnel.cs

@@ -190,7 +190,7 @@ public void modifyBinaryPermission()
       }
     }
 
-    private string fetchSourceUrl(string accessKey)
+    protected virtual string fetchSourceUrl(string accessKey)
     {
       var url = "https://local.browserstack.com/binary/api/v1/endpoint";