This repository was archived by the owner on Jan 12, 2026. It is now read-only.
[task_05] Lab5#329
Open
tgoyshik wants to merge 88 commits into
Open
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds documentation and images for laboratory work №3 (PID controller simulation) to the task_04 directory for student ii02804. However, there are several inconsistencies between the PR title, file locations, and referenced paths.
Key Changes
- Added comprehensive readme.md documentation for a PID controller simulation lab in
trunk/ii02804/task_04/doc/ - Added 26 supporting image files (PNG format) to
trunk/ii02804/task_04/doc/images/ - Modified GitHub workflow configuration to adjust duplication check thresholds
Reviewed changes
Copilot reviewed 2 out of 30 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| trunk/ii02804/task_04/doc/readme.md | Documentation for laboratory work №3 on PID controllers - contains multiple incorrect path references |
| trunk/ii02804/task_04/doc/images/*.png | 26 image files (binary content) supporting the documentation |
| .github/workflows/check_duplication.yml | Updated duplication threshold from 92% to 93% and added ignore directories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <p align="center">“Брестский Государственный технический университет”</p> | ||
| <p align="center">Кафедра ИИТ</p> | ||
| <br><br><br><br><br><br><br> | ||
| <p align="center">Лабораторная работа №3</p> |
There was a problem hiding this comment.
The PR title indicates this is for "task_05 lab5", but all the actual content being added is for task_04. The documentation is being placed in trunk/ii02804/task_04/doc/, and the readme file at line 6 states this is "Лабораторная работа №3" (Laboratory work №3). There is a mismatch between the PR title and the actual content.
Comment on lines
+19
to
+23
| 1. Написать отчет по выполненной лабораторной работе №3 в .md формате (*readme.md*) и разместить его в следующем каталоге: **trunk\ii0xxyy\task_03\doc**. | ||
| 2. Исходный код написанной программы разместить в каталоге: **trunk\ii0xxyy\task_03\src**. | ||
| 3. Отразить выполнение работы в файле readme.md в соответствующей строке (например, для студента под порядковым номером 1 - https://github.com/brstu/OTIS-2025/edit/main/readme.md?#L17-L17). | ||
| 4. Документировать исходный код программы с помощью комментариев в стиле **Doxygen**. Полученную документацию разместить в каталоге: **trunk\ii0xxyy\task_03\doc\html**. Настроить `GitHub Pages` для автоматической публикации документации из этого каталога. | ||
| 5. Разработанная программа также должна быть покрыта модульными тестами, написанными с использованием **Google Test**. Тесты разместить в каталоге: **trunk\ii0xxyy\task_03\test**. |
There was a problem hiding this comment.
Lines 19-23 reference "task_03" paths (e.g., "trunk\ii0xxyy\task_03\doc"), but this documentation is for task_04. The paths should be updated to reference "task_04" to match the actual location of the files and avoid confusion.
Suggested change
| 1. Написать отчет по выполненной лабораторной работе №3 в .md формате (*readme.md*) и разместить его в следующем каталоге: **trunk\ii0xxyy\task_03\doc**. | |
| 2. Исходный код написанной программы разместить в каталоге: **trunk\ii0xxyy\task_03\src**. | |
| 3. Отразить выполнение работы в файле readme.md в соответствующей строке (например, для студента под порядковым номером 1 - https://github.com/brstu/OTIS-2025/edit/main/readme.md?#L17-L17). | |
| 4. Документировать исходный код программы с помощью комментариев в стиле **Doxygen**. Полученную документацию разместить в каталоге: **trunk\ii0xxyy\task_03\doc\html**. Настроить `GitHub Pages` для автоматической публикации документации из этого каталога. | |
| 5. Разработанная программа также должна быть покрыта модульными тестами, написанными с использованием **Google Test**. Тесты разместить в каталоге: **trunk\ii0xxyy\task_03\test**. | |
| 1. Написать отчет по выполненной лабораторной работе №3 в .md формате (*readme.md*) и разместить его в следующем каталоге: **trunk\ii0xxyy\task_04\doc**. | |
| 2. Исходный код написанной программы разместить в каталоге: **trunk\ii0xxyy\task_04\src**. | |
| 3. Отразить выполнение работы в файле readme.md в соответствующей строке (например, для студента под порядковым номером 1 - https://github.com/brstu/OTIS-2025/edit/main/readme.md?#L17-L17). | |
| 4. Документировать исходный код программы с помощью комментариев в стиле **Doxygen**. Полученную документацию разместить в каталоге: **trunk\ii0xxyy\task_04\doc\html**. Настроить `GitHub Pages` для автоматической публикации документации из этого каталога. | |
| 5. Разработанная программа также должна быть покрыта модульными тестами, написанными с использованием **Google Test**. Тесты разместить в каталоге: **trunk\ii0xxyy\task_04\test**. |
Comment on lines
+210
to
+223
|  | ||
|  | ||
|
|
||
| ### `Нелинейная функция` | ||
|  | ||
|
|
||
| ## Графики | ||
| ### При `K = 0.5 T = 2.0 T0 = 1.0 TD = 0.3 a = 0.8 b = 0.1 y0 = 20 w = 100` | ||
|
|
||
|  | ||
| <br> | ||
|
|
||
| ### При `K = 0.5 T = 2.0 T0 = 1.0 TD = 0.3 a = 0.8 b = 0.1 c = 0.05 d = 0.03 y0 = 20 w = 100` | ||
|  |
There was a problem hiding this comment.
The image URLs at lines 210-214 and 219, 223 reference branches and paths from "task_03" (e.g., "blob/task_03/trunk/ii02804/task_03/doc/images/"). These should be updated to reference "task_04" to correctly point to the images in the current task directory.
Suggested change
|  | |
|  | |
| ### `Нелинейная функция` | |
|  | |
| ## Графики | |
| ### При `K = 0.5 T = 2.0 T0 = 1.0 TD = 0.3 a = 0.8 b = 0.1 y0 = 20 w = 100` | |
|  | |
| <br> | |
| ### При `K = 0.5 T = 2.0 T0 = 1.0 TD = 0.3 a = 0.8 b = 0.1 c = 0.05 d = 0.03 y0 = 20 w = 100` | |
|  | |
|  | |
|  | |
| ### `Нелинейная функция` | |
|  | |
| ## Графики | |
| ### При `K = 0.5 T = 2.0 T0 = 1.0 TD = 0.3 a = 0.8 b = 0.1 y0 = 20 w = 100` | |
|  | |
| <br> | |
| ### При `K = 0.5 T = 2.0 T0 = 1.0 TD = 0.3 a = 0.8 b = 0.1 c = 0.05 d = 0.03 y0 = 20 w = 100` | |
|  |
|
|
||
| ``` | ||
| ## Результаты юнит-тестирования (GoogleTest) | ||
|  |
There was a problem hiding this comment.
The image URL at line 448 references "blob/task_03/trunk/ii02804/task_03/doc/images/test.png". This should be updated to reference "task_04" to correctly point to the test.png image in the current task directory.
Suggested change
|  | |
|  |
Comment on lines
+448
to
+452
|  | ||
|
|
||
| ## Покрытие GCC Code Coverage | ||
|
|
||
|  |
There was a problem hiding this comment.
The image URL at line 452 references "blob/task_03/trunk/ii02804/task_03/doc/images/coverage.png". This should be updated to reference "task_04" to correctly point to the coverage.png image in the current task directory.
Suggested change
|  | |
| ## Покрытие GCC Code Coverage | |
|  | |
|  | |
| ## Покрытие GCC Code Coverage | |
|  |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.