[task_03] Did task_03#358
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a PID (Proportional-Integral-Derivative) temperature control system simulation as part of task_03. The implementation includes a PID controller class, simulation program, visualization tools, comprehensive documentation, and unit tests using Google Test.
Key changes include:
- Complete PID controller implementation with tunable parameters
- Temperature model simulation with noise injection
- Python visualization scripts for data analysis
- Unit tests covering proportional control and output limiting
Reviewed changes
Copilot reviewed 13 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| trunk/ii02710/task_03/test/test_pid_basic.cpp | Unit tests for PID controller functionality |
| trunk/ii02710/task_03/test/build-and-run-project.bat | Build script for test project |
| trunk/ii02710/task_03/test/CMakeLists.txt | CMake configuration for tests with Google Test |
| trunk/ii02710/task_03/src/temperature_data.csv | Generated simulation data output |
| trunk/ii02710/task_03/src/simulation.cpp | Main simulation program with PID control loop |
| trunk/ii02710/task_03/src/plot_temperature.py | Python visualization and analysis scripts |
| trunk/ii02710/task_03/src/pid_controller.h | PID controller class header |
| trunk/ii02710/task_03/src/pid_controller.cpp | PID controller implementation |
| trunk/ii02710/task_03/src/build-and-run-project.bat | Build and run script for simulation |
| trunk/ii02710/task_03/src/CMakeLists.txt | CMake configuration for simulation |
| trunk/ii02710/task_03/doc/html/index.md | API documentation |
| trunk/ii02710/task_03/doc/README.md | Project documentation and report |
| trunk/ii02710/task_02/googletest | Google Test submodule reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
trunk/ii02710/task_03/src/simulation.cpp:1
- The comment contains corrupted text encoding. Use proper UTF-8 encoding for comments or convert the comment to English.
/**
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 20 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PIDController pid(2.5, 0.5, 1.0, 0, 100); | ||
|
|
||
| double setpoint; | ||
| std::cout << "Write SetPoint: "; |
There was a problem hiding this comment.
The prompt 'Write SetPoint' uses inconsistent capitalization. Consider using 'Enter Setpoint:' or 'Write setpoint:' for consistency with the rest of the codebase where 'setpoint' is typically lowercase.
| std::cout << "Write SetPoint: "; | |
| std::cout << "Enter setpoint: "; |
No description provided.