Remove TTS — extracted to the standalone VanillaTTS DLL

C_VoiceChat / C_TTSSettings (the SAPI text-to-speech surface) is moving to
its own injected DLL (C:\Git\VanillaTTS) so it can grow a cross-platform
software-synthesis backend (Flite under Wine) without bloating ClassicAPI.

- Delete src/voicechat/Tts.cpp.
- Drop the ole32 link from CMakeLists (it was only for SAPI/COM).
- Strip the VoiceChat section + TOC from docs/API.md and the VoiceChat
  row + VOICE_CHAT_TTS_* events from the README.

CVar::Factory stays — it's general-purpose infra now, not TTS-specific
(reworded its header comment to drop the TTS example).

Author: brues-code

CMakeLists.txt

@@ -99,10 +99,7 @@ target_compile_definitions(
   ${PROJECT_NAME}
   PRIVATE CLASSICAPI_VERSION_VALUE=${CLASSICAPI_VERSION_VALUE})
 
-# ole32: COM (CoInitializeEx / CoCreateInstance / CoTaskMemFree) for the
-# SAPI text-to-speech backend in src/voicechat/Tts.cpp. The SAPI GUIDs are
-# instantiated in that TU via <initguid.h>, so no sapi.lib is needed.
-target_link_libraries(${PROJECT_NAME} PRIVATE minhook advapi32 ole32)
+target_link_libraries(${PROJECT_NAME} PRIVATE minhook advapi32)
 
 target_include_directories(
   ${PROJECT_NAME} PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src

README.md

@@ -59,7 +59,6 @@ Full per-function reference: **[docs/API.md](docs/API.md)**.
 | [UIColor](docs/API.md#uicolor) | `C_UIColor.GetColors` |
 | [Unit](docs/API.md#unit) | `GetUnitSpeed`, `UnitClassBase`, `UnitGUID`, `UnitInRange`, `UnitIsAFK`, `UnitIsDND`, `UnitIsFeignDeath`, `UnitIsInMyGuild`, `UnitIsPossessed`, `UnitPower`, `UnitPowerMax`, `UnitPowerType`, `UnitRaceBase`, `UnitStandState`, `UnitSubName`, `UnitTokenFromGUID` |
 | [UnitAuras](docs/API.md#unitauras) | `C_UnitAuras.GetAuraDataByIndex`, `C_UnitAuras.GetAuraDataBySpellName`, `C_UnitAuras.GetAuraDispelTypeColor`, `C_UnitAuras.GetBuffDataByIndex`, `C_UnitAuras.GetDebuffDataByIndex`, `C_UnitAuras.GetPlayerAuraBySpellID`, `C_UnitAuras.GetUnitAuraBySpellID`, `C_UnitAuras.GetUnitAuras` |
-| [VoiceChat](docs/API.md#voicechat) | `C_VoiceChat.GetTtsVoices`, `C_VoiceChat.GetRemoteTtsVoices`, `C_VoiceChat.SpeakText`, `C_VoiceChat.StopSpeakingText`, `C_TTSSettings.GetSpeechRate`, `C_TTSSettings.GetSpeechVolume`, `C_TTSSettings.GetSpeechVoiceID`, `C_TTSSettings.GetVoiceOptionName`, `C_TTSSettings.SetSpeechRate`, `C_TTSSettings.SetSpeechVolume`, `C_TTSSettings.SetVoiceOption`, `C_TTSSettings.SetVoiceOptionByName`, `C_TTSSettings.SetDefaultSettings`, `C_TTSSettings.RefreshVoices` |
 
 ### GlueXML calls
 
@@ -133,10 +132,6 @@ when launching with `-console`), not as Lua functions. See the
 | `QUEST_DATA_LOAD_RESULT` | `questID, success` |
 | `QUEST_TURNED_IN` | `questID, xpReward, moneyReward` |
 | `UPDATE_SHAPESHIFT_FORM` | *(none)* |
-| `VOICE_CHAT_TTS_PLAYBACK_STARTED` | `numConsumers, utteranceID, durationMS, destination` |
-| `VOICE_CHAT_TTS_PLAYBACK_FINISHED` | `numConsumers, utteranceID, destination` |
-| `VOICE_CHAT_TTS_PLAYBACK_FAILED` | `status, utteranceID, destination` |
-| `VOICE_CHAT_TTS_VOICES_UPDATE` | *(none)* |
 
 ### Globals
 

docs/API.md

@@ -392,14 +392,6 @@ build instructions.
   - [`C_UnitAuras.GetUnitAuras(unit [, filter])`](#c_unitaurasgetunitaurasunit--filter)
   - [`C_UnitAuras.GetAuraDispelTypeColor(dispelName)`](#c_unitaurasgetauradispeltypecolordispelname)
 
-- [VoiceChat](#voicechat)
-  - [`C_VoiceChat.GetTtsVoices()` / `C_VoiceChat.GetRemoteTtsVoices()`](#c_voicechatgetttsvoices--c_voicechatgetremotettsvoices)
-  - [`C_VoiceChat.SpeakText(voiceID, text [, destination, rate, volume])`](#c_voicechatspeaktextvoiceid-text--destination-rate-volume)
-  - [`C_VoiceChat.StopSpeakingText()`](#c_voicechatstopspeakingtext)
-  - [`C_TTSSettings` — getters & setters](#c_ttssettings--getters--setters)
-  - [TTS events](#tts-events)
-  - [TTS CVars](#tts-cvars)
-
 ## Account
 
 ### `SaveAccount(name, password)` / `DeleteAccount(name)` / `GetSavedAccounts()` / `LoginWithSavedAccount(name)` — GlueXML only
@@ -9463,122 +9455,3 @@ builds. So the returned value carries the mixin methods
 `.r/.g/.b/.a` fields. Falls back to a plain `{r,g,b,a}` table if
 `CreateColor` isn't loaded yet (shouldn't happen — `!!!ClassicAPI`
 loads first thanks to the triple-`!` prefix).
-
-## VoiceChat
-
-Backport of modern WoW's text-to-speech surface — the `C_VoiceChat` and
-`C_TTSSettings` namespaces — backed by **Windows SAPI** (the OS speech
-engine). All playback is **local** (rendered on your own machine);
-vanilla 1.12 has no voice-chat transport, so there is nothing "remote" to
-transmit synthesized speech into.
-
-SAPI is created lazily on first use. If SAPI is unavailable (e.g. running
-the client under Wine, or a stripped Windows), every call degrades
-gracefully: `GetTtsVoices` returns an empty table, `SpeakText` fires
-`VOICE_CHAT_TTS_PLAYBACK_FAILED` and does nothing, and the client stays
-stable — there is no crash. Install more voices under **Windows Settings →
-Time & Language → Speech**, then call `C_TTSSettings.RefreshVoices()`.
-
-### `C_VoiceChat.GetTtsVoices()` / `C_VoiceChat.GetRemoteTtsVoices()`
-
-Return a numerically-indexed array of voice tables — one per SAPI voice
-installed on the machine:
-
-```lua
-for _, v in ipairs(C_VoiceChat.GetTtsVoices()) do
-    print(v.voiceID, v.name)   -- e.g.  0  "Microsoft David Desktop - English (United States)"
-end
-```
-
-Each entry is `{ voiceID = <0-based index>, name = <display name> }`. The
-`voiceID` is the index you pass to `SpeakText` and store via
-`C_TTSSettings.SetVoiceOption`. `GetRemoteTtsVoices` is an alias returning
-the same local list (kept for API parity — vanilla has no voice chat).
-Calling either refreshes the cached voice list and fires
-`VOICE_CHAT_TTS_VOICES_UPDATE` if it changed.
-
-### `C_VoiceChat.SpeakText(voiceID, text [, destination, rate, volume])`
-
-Speaks `text` aloud using the SAPI voice at index `voiceID`.
-
-```lua
-C_VoiceChat.SpeakText(
-    C_TTSSettings.GetSpeechVoiceID(),         -- use the configured voice
-    UnitName("target") or "no target")
-```
-
-- **`voiceID`** (number, required) — index into `GetTtsVoices()`. Note this
-  is an **explicit argument** — `SpeakText` does *not* read the `ttsVoice`
-  cvar itself, matching Blizzard's contract. Pass
-  `C_TTSSettings.GetSpeechVoiceID()` to honor the configured default.
-- **`text`** (string, required) — UTF-8; spoken as-is.
-- **`destination`** (number, optional, default `1`) — `1` =
-  `LOCAL_PLAYBACK`, `4` = `QUEUED_LOCAL_PLAYBACK`. Accepted for parity;
-  both queue FIFO through SAPI (no app-side queue).
-- **`rate`** (number, optional, default `0`) — speech rate, clamped to
-  `[-10, 10]`.
-- **`volume`** (number, optional, default `100`) — clamped to `[0, 100]`.
-
-Speech is asynchronous. The call returns immediately and fires
-`VOICE_CHAT_TTS_PLAYBACK_STARTED` when SAPI begins the utterance and
-`VOICE_CHAT_TTS_PLAYBACK_FINISHED` when it completes (or
-`..._PLAYBACK_FAILED` if the voice/engine is unavailable). Raises a Lua
-error if `voiceID` isn't a number or `text` isn't a string.
-
-### `C_VoiceChat.StopSpeakingText()`
-
-Stops and purges everything currently playing or queued.
-
-### `C_TTSSettings` — getters & setters
-
-The settings store (separate from `SpeakText`, which takes its parameters
-explicitly). All three values are backed by CVars (see below), so they
-**persist across sessions** and are clamped to valid ranges on write.
-
-| Function | Returns / effect |
-|---|---|
-| `C_TTSSettings.GetSpeechRate()` | configured rate, `[-10, 10]` (default `0`) |
-| `C_TTSSettings.GetSpeechVolume()` | configured volume, `[0, 100]` (default `100`) |
-| `C_TTSSettings.GetSpeechVoiceID()` | configured voice index (default `0`) |
-| `C_TTSSettings.GetVoiceOptionName()` | display name of the configured voice, or `""` |
-| `C_TTSSettings.SetSpeechRate(rate)` | set rate (clamped) |
-| `C_TTSSettings.SetSpeechVolume(volume)` | set volume (clamped) |
-| `C_TTSSettings.SetVoiceOption(voiceID)` | set the voice by index (clamped to installed count) |
-| `C_TTSSettings.SetVoiceOptionByName(name)` | set the voice by display name (case-insensitive exact match) |
-| `C_TTSSettings.SetDefaultSettings()` | reset to voice `1` (if present, else `0`), rate `0`, volume `100` |
-| `C_TTSSettings.RefreshVoices()` | re-enumerate SAPI voices; fires `VOICE_CHAT_TTS_VOICES_UPDATE` if the list changed |
-
-```lua
-C_TTSSettings.SetVoiceOptionByName("Microsoft Zira Desktop - English (United States)")
-C_TTSSettings.SetSpeechVolume(150)              -- clamps to 100
-print(C_TTSSettings.GetVoiceOptionName())       -- "Microsoft Zira Desktop - ..."
-```
-
-### TTS events
-
-Registered like any engine event (`frame:RegisterEvent("VOICE_CHAT_TTS_PLAYBACK_STARTED")`).
-
-| Event | Args |
-|---|---|
-| `VOICE_CHAT_TTS_PLAYBACK_STARTED` | `numConsumers` (number), `utteranceID` (number), `durationMS` (number, always `0`), `destination` (number) |
-| `VOICE_CHAT_TTS_PLAYBACK_FINISHED` | `numConsumers` (number), `utteranceID` (number), `destination` (number) |
-| `VOICE_CHAT_TTS_PLAYBACK_FAILED` | `status` (string — e.g. `"EngineAllocationFailed"`, `"InternalError"`), `utteranceID` (number), `destination` (number) |
-| `VOICE_CHAT_TTS_VOICES_UPDATE` | *(none)* — the installed-voice list changed |
-| `VOICE_CHAT_TTS_SPEAK_TEXT_UPDATE` | reserved for parity; not currently fired |
-
-`utteranceID` correlates the START/FINISHED/FAILED events for a given
-`SpeakText` call. `PLAYBACK_FINISHED` fires only when playback actually
-completes, so it's the signal to start the next utterance in a queue.
-
-### TTS CVars
-
-The `C_TTSSettings` values are stored as engine CVars, persisted to
-`WTF\Config.wtf`. You can also read/write them with the standard
-`GetCVar`/`SetCVar` (or `/console set`); writes are clamped by the same
-validation:
-
-| CVar | Default | Range | Backing setting |
-|---|---|---|---|
-| `ttsVoice` | `0` | `[0, voiceCount-1]` | `GetSpeechVoiceID` / `SetVoiceOption` |
-| `ttsSpeed` | `0` | `[-10, 10]` | `GetSpeechRate` / `SetSpeechRate` |
-| `ttsVolume` | `100` | `[0, 100]` | `GetSpeechVolume` / `SetSpeechVolume` |

src/cvar/Factory.h

@@ -22,8 +22,8 @@
 // an addon to register a cvar with a change-callback or to react to value
 // changes. This wraps the engine's internal registrar (`FUN_REGISTER_CVAR`)
 // and value-setter (`FUN_SET_CVAR_VALUE`) so other modules can publish
-// persisted, validated settings — e.g. the TTS module's ttsVoice / ttsSpeed
-// / ttsVolume.
+// persisted, validated settings (clamped via the change callback and saved
+// to Config.wtf).
 //
 // CVars registered here persist to `WTF\Config.wtf` (the engine forces the
 // archive flag bit on at registration) and are visible to the in-game Lua