Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

[Metrics][Observability] Add basic Prometheus metrics to PEAS, including /healthz and /pprof#15

Merged
commoddity merged 9 commits into
mainfrom
peas-metrics
Sep 15, 2025
Merged

[Metrics][Observability] Add basic Prometheus metrics to PEAS, including /healthz and /pprof#15
commoddity merged 9 commits into
mainfrom
peas-metrics

Conversation

@commoddity
Copy link
Copy Markdown
Contributor

@commoddity commoddity commented Sep 11, 2025 •
edited
Loading

🌿 Summary

Add comprehensive Prometheus metrics to PEAS including authorization tracking, rate limiting, and system health monitoring with a Grafana dashboard for observability.

🌱 Primary Changes:

  • Added Prometheus metrics server with /metrics, /healthz, and /debug/pprof endpoints
  • Implemented authorization request tracking with labels for portal app, account, status, and error types
  • Added rate limiting metrics including account usage tracking and rate limit decisions
  • Created comprehensive Grafana dashboard for monitoring authorization performance and system health

🍃 Secondary changes:

  • Updated environment configuration with new metrics and pprof ports
  • Enhanced documentation with metrics overview and local development setup
  • Added local development stack with Docker Compose for Prometheus and Grafana
  • Created script for generating auth traffic for local development stack

@commoddity commoddity requested a review from Olshansk September 11, 2025 20:14
@commoddity commoddity self-assigned this Sep 11, 2025
Olshansk
Olshansk suggested changes Sep 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commoddity

  1. I pushed one small commit. PTAL.
  2. Left a few comments.
  3. Only got about ~30% of the way through but will finish on monday.

Comment thread ratelimit/ratelimit_store.go Outdated
Comment thread ratelimit/ratelimit_store.go Outdated
Comment thread ratelimit/ratelimit_store.go
Comment thread ratelimit/ratelimit_store.go
Comment thread ratelimit/ratelimit_store.go Outdated
Comment thread auth/auth_handler.go Outdated
Comment thread auth/auth_handler.go Outdated
Comment thread auth/auth_handler.go
Comment thread metrics.go Outdated
Pascal van Leeuwen and others added 2 commits September 15, 2025 14:06
@claude
Code review improvements: enhance DevEx and code quality
bdfc228 
- Add explanatory comments for rate limiting logic flow
- Improve struct organization with logical groupings
- Format histogram buckets for better readability
- Add strategic TODOs for testing and monitoring
- Fix minor punctuation and consistency issues

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
fix: implement review comments
a1c1958
@commoddity commoddity requested a review from Olshansk September 15, 2025 15:31
@commoddity commoddity merged commit 09cf476 into main Sep 15, 2025
3 checks passed
@commoddity commoddity deleted the peas-metrics branch September 15, 2025 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fredteumer fredteumer Awaiting requested review from fredteumer

@Olshansk Olshansk Awaiting requested review from Olshansk

Assignees

@commoddity commoddity

Labels

metrics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@commoddity @Olshansk