Updating lesnfun database is giving an error

[smartgoblin]

Description:

Action: Edit - Data Update

Issue: action does not work with error message

Expected: an update lensfun db

OS: windows 10 and latest rawproc

[butcherg]

In the About dialog (Help -> About...), let me know what path is specified in the "Lensfun Database: " line.

I just tried it here, still works... My guesses at this point would be 1) trying to update the database in a place in your filesystem for which you don't have write permissions, or 2) something in your network path is preventing connection to the lensfun database server.

[smartgoblin]

I did set a new path for the lensfun db as in the screenshot.

What URI is the application using to contact the lensfun db?

[butcherg]

https://lensfun.sourceforge.net/db/

Inspecting the code, that error message is specifically about not finding "2" in the versions.json file retrieved from that URL. Use your browser to get this:

https://lensfun.sourceforge.net/db/versions.json

and the result should look like this:

[1704279921, [0, 1, 2], []]

The first value is the timestamp of the current database, and the list 0,1,2 are the versions available.

If you can do the above with your browser, I'm not sure why rawproc can't...

[smartgoblin]

Well for the first url its clear there is an issue at sourceforge:

For the second one I indeed receive this data back:

[ 1704279921, [ 0, 1, 2 ], [] ]

[butcherg]

That's interesting, I can see the sourceforge URL just fine here in Colorado, USA...

I switched from bronger to sourceforge early in coding this, thought it would be the more stable source. If you can go into src/lensfun_dbupdate.cpp and change line 36 to LENSFUN_BRONGER_URL, that should get you going.

I'm going to do what I should have back when I implemented this, make the URL a changeable rawproc property...

[butcherg]

Oh, I just looked more closely at your screenshot, the URL in the browser didn't end with 'versions.json'. When I try the same URL, I get the same error page. Y'might try sourceforge again, with:

https://lensfun.sourceforge.net/db/versions.json

Edit: and, if that works, then it's back to the drawing board...

[smartgoblin]

That is all right see my previous comment, tested even from a VPN to New-Zealand:

For myself I'm on windows (c# dev) and don't know yet how to debug this c and cpp apps build initially on Linux.

[butcherg]

Since I can't replicate it here, if you don't mind I'll ask you to do a bit of debugging like this:

in src/lensfun_dbupdate.cpp, go to line 317;
in the next line, put this code:

printf("versions.json: %s\n", versions.c_str()); fflush(stdout);

recompile rawproc, run it from the command line, and try the data update menu item. Report back with what rawproc prints on the command line...

Thanks,
Glenn

[smartgoblin]

I would greatly try that.
Now being on windows...
Will have to try via msys64.

[butcherg]

Oh, thought you were compiling...

Got to go to an appointment, I can make a win32 executable when I get back.

[smartgoblin]

No problem, in the meantime I will also try it myself.

Cheers,
Charly

[smartgoblin]

I think I do have all packages needed, but the make command is giving me info that its not finding the target to make?

Did not find directly on the web what do to here.

[butcherg]

Ah, msys2 cmake changed their default build system, wants to use ninja. Do this:

$ cmake -G "MSYS Makefiles" (and the rest of the cmake command line)...

I'm building a debug win32 executable now, will upload it to my personal server.

[smartgoblin]

There are compiling issues, I have seen that with Darktable build for example and I think it was linked to the compiler used.

My output log:

`charly@DESKTOP-70269QA MSYS ~
$ git clone https://github.com/butcherg/rawproc.git
Cloning into 'rawproc'...
remote: Enumerating objects: 11372, done.
remote: Counting objects: 100% (779/779), done.
remote: Compressing objects: 100% (304/304), done.
remote: Total 11372 (delta 543), reused 693 (delta 475), pack-reused 10593
Receiving objects: 100% (11372/11372), 12.94 MiB | 10.47 MiB/s, done.
Resolving deltas: 100% (8584/8584), done.

charly@DESKTOP-70269QA MSYS ~
$ cd rawproc/

charly@DESKTOP-70269QA MSYS ~/rawproc
$ mkdir build-windows

charly@DESKTOP-70269QA MSYS ~/rawproc
$ cd build-windows/

charly@DESKTOP-70269QA MSYS ~/rawproc/build-windows
$ cmake .. -G "MSYS Makefiles"
CMAKE_HOST_SYSTEM_NAME Windows
CMAKE_HOST_SYSTEM_VERSION
-- The CXX compiler identification is GNU 13.2.0
-- The C compiler identification is GNU 13.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/msys64/ucrt64/bin/c++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/msys64/ucrt64/bin/cc.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found OpenMP_C: -fopenmp (found version "4.5")
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- Found wxWidgets: -LC:/msys64/ucrt64/lib;;;-pipe;-Wl,--subsystem,windows;-mwindows;-lwx_mswu_aui-3
.2;-lwx_mswu_propgrid-3.2;-lwx_mswu_xrc-3.2;-lwx_mswu_html-3.2;-lwx_mswu_qa-3.2;-lwx_mswu_core-3.2;-
lwx_baseu_xml-3.2;-lwx_baseu_net-3.2;-lwx_baseu-3.2 (found version "3.2.4")
-- includes: C:/msys64/ucrt64/share/cmake/Modules/UsewxWidgets.cmake
-- Found PkgConfig: C:/msys64/ucrt64/bin/pkg-config.exe (found version "2.1.0")
-- Found JPEG: C:/msys64/ucrt64/lib/libjpeg.dll.a (found version "80")
-- Found TIFF: C:/msys64/ucrt64/lib/libtiff.dll.a (found version "4.6.0")
-- Found ZLIB: C:/msys64/usr/lib/libz.dll.a (found version "1.3")
-- Found PNG: C:/msys64/ucrt64/lib/libpng.dll.a (found version "1.6.40")
-- Checking for module 'lcms2'
-- Found lcms2, version 2.16
-- Checking for module 'libraw'
-- Found libraw, version 0.21.2
-- Checking for module 'lensfun'
-- Found lensfun, version 0.3.4.0
-- Checking for module 'exiv2'
-- Found exiv2, version 0.28.1
-- Configuring done (9.5s)
-- Generating done (0.1s)
-- Build files have been written to: C:/msys64/home/charly/rawproc/build-windows

charly@DESKTOP-70269QA MSYS ~/rawproc/build-windows
$ make
[ 1%] Building CXX object CMakeFiles/rawproc.dir/src/rawprocApp.cpp.obj
[ 2%] Building CXX object CMakeFiles/rawproc.dir/src/curve.cpp.obj
[ 3%] Building CXX object CMakeFiles/rawproc.dir/src/CurvePane.cpp.obj
C:/msys64/home/charly/rawproc/src/CurvePane.cpp: In constructor 'CurvePane::CurvePane(wxWindow*, wxS
tring)':
C:/msys64/home/charly/rawproc/src/CurvePane.cpp:58:35: error: cannot convert '__gnu_cxx::__alloc_tra
its<std::allocator, wxString>::value_type' {aka 'wxString'} to 'const char*'
58 | c.insertpoint(atof(ctrlpts[i]), atof(ctrlpts[i+1]));
| ~~~~^~~~~~~~~~~~
| |
| __gnu_cxx::__alloc_traits<std::allocator, wxStri
ng>::value_type {aka wxString}
In file included from C:/msys64/ucrt64/include/c++/13.2.0/cstdlib:79,
from C:/msys64/ucrt64/include/c++/13.2.0/stdlib.h:36,
from C:/msys64/ucrt64/include/assert.h:17,
from C:/msys64/ucrt64/include/wx-3.2/wx/debug.h:13,
from C:/msys64/ucrt64/include/wx-3.2/wx/defs.h:1010,
from C:/msys64/ucrt64/include/wx-3.2/wx/wx.h:14,
from C:/msys64/home/charly/rawproc/src/CurvePane.h:5,
from C:/msys64/home/charly/rawproc/src/CurvePane.cpp:1:
C:/msys64/ucrt64/include/stdlib.h:431:35: note: initializing argument 1 of 'double atof(const char
*)'
431 | double __cdecl atof(const char _String);
| ~~~~~~~~~~~~^~~~~~~
C:/msys64/home/charly/rawproc/src/CurvePane.cpp:58:53: error: cannot convert '__gnu_cxx::__alloc_tra
its<std::allocator, wxString>::value_type' {aka 'wxString'} to 'const char'
58 | c.insertpoint(atof(ctrlpts[i]), atof(ctrlpts[i+1]));
| ~~~~^~~~~~~~~~~~~~
| |
| __gnu_cxx::__alloc_traits<std::allocator
, wxString>::value_type {aka wxString}
C:/msys64/ucrt64/include/stdlib.h:431:35: note: initializing argument 1 of 'double atof(const char
*)'
431 | double __cdecl atof(const char *_String);
| ~~~~~~~~~~~~^~~~~~~
make[2]: *** [CMakeFiles/rawproc.dir/build.make:104: CMakeFiles/rawproc.dir/src/CurvePane.cpp.obj] Error 1
make[1]: *** [CMakeFiles/Makefile2:107: CMakeFiles/rawproc.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

charly@DESKTOP-70269QA MSYS ~/rawproc/build-windows`

It's late in my timezone will continue on that after some sleep.

Glenn how are you building this for windows?

Kind regards,
Charly

[butcherg]

I'm using MXE to make a static executable. Not working right now, I think I configured my supporting packages out from under win32 rawproc...

To your errors, I think using wxWidgets 3.2 might have deprecated a wxString implicit conversion. If so, that'll be a rather ambitious change. Let me pick at that for a bit... thanks for your patience!