fix: share deadline-aware alert tap synthesis

Author: thymikee

apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+Alert.swift

@@ -1,5 +1,4 @@
 import XCTest
-import AgentDeviceSnapshotPresentation
 
 extension RunnerTests {
   enum RunnerAlertSource {
@@ -148,52 +147,22 @@ extension RunnerTests {
           )
           return
         }
-        guard let context = synthesizedCoordinateContext(
-          app: alert.ownerApp,
-          policy: synthesizedGesturePolicy(.coordinateTap)
-        ) else {
-          outcome = .unsupported(
-            message: "alert activation could not resolve its application window",
-            hint: "Inspect the current alert before deciding whether to act again."
-          )
-          return
-        }
-        let orientation = Int(RunnerSynthesizedGesture.interfaceOrientation(forApplication: alert.ownerApp))
-        let point = CoordinateSpaceRotation.native(
-          point: CGPoint(x: frame.midX, y: frame.midY),
-          in: context.referenceFrame,
-          interfaceOrientation: orientation
-        )
-        var message: NSString?
-        let status = RunnerSynthesizedGesture.synthesizeTap(
-          withApplication: alert.ownerApp,
-          resolvedWindow: context.resolvedWindow,
-          x: Double(point.x),
-          y: Double(point.y),
-          deadline: deadline,
-          errorMessage: &message
-        )
-        switch status {
-        case .succeeded:
+        switch synthesizedTapAt(app: alert.ownerApp, x: frame.midX, y: frame.midY, deadline: deadline) {
+        case .performed?:
           typealias WaitForQuiescence = @convention(c) (NSObject, Selector, Bool) -> Void
           let waitForQuiescence = unsafeBitCast(
             alert.ownerApp.method(for: postEventWaitSelector),
             to: WaitForQuiescence.self
           )
           waitForQuiescence(alert.ownerApp, postEventWaitSelector, false)
           outcome = .performed
-        case .deadlineExceeded:
-          outcome = nil
-        case .failed:
-          outcome = .unsupported(
-            message: message as String? ?? "private XCTest event synthesis failed",
-            hint: "Inspect the current alert before deciding whether to act again."
-          )
-        @unknown default:
+        case .unsupported(let message, _)?:
           outcome = .unsupported(
-            message: "private XCTest event synthesis returned an unknown status",
+            message: message,
             hint: "Inspect the current alert before deciding whether to act again."
           )
+        case nil:
+          break
         }
 #else
         outcome = activateElement(

apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+SynthesizedGesturePolicy.swift

@@ -143,9 +143,14 @@ extension RunnerTests {
     _ app: XCUIApplication,
     kind: SynthesizedGesturePolicyKind,
     context: SynthesizedCoordinateContext?,
-    synthesize: () -> RunnerInteractionOutcome
+    synthesize: () -> RunnerInteractionOutcome?
   ) -> SynthesizedGestureAttempt {
-    let (timing, outcome) = performGesture(app, idleTimeout: false, synthesize)
+    var outcome: RunnerInteractionOutcome?
+    let timing = measureGesture { outcome = synthesize() }
+    guard let outcome else {
+      logSynthesizedGesturePolicyDecision(kind: kind, context: context, fallbackAttempted: false)
+      return .refused(timing: timing, message: "synthesized gesture deadline expired before dispatch", hint: nil)
+    }
     guard case .unsupported(let message, let hint) = outcome else {
       logSynthesizedGesturePolicyDecision(kind: kind, context: context, fallbackAttempted: false)
       return .performed(timing: timing)

apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+SynthesizedInteraction.swift

@@ -95,8 +95,9 @@ extension RunnerTests {
     app: XCUIApplication,
     x: Double,
     y: Double,
-    context: SynthesizedCoordinateContext? = nil
-  ) -> RunnerInteractionOutcome {
+    context: SynthesizedCoordinateContext? = nil,
+    deadline: Date? = nil
+  ) -> RunnerInteractionOutcome? {
 #if os(iOS)
     guard x.isFinite, y.isFinite else {
       return .unsupported(
@@ -132,16 +133,25 @@ extension RunnerTests {
       resolvedWindow: context.resolvedWindow,
       x: Double(point.x),
       y: Double(point.y),
-      deadline: nil,
+      deadline: deadline,
       errorMessage: &message
     )
-    if status != .succeeded {
+    switch status {
+    case .succeeded:
+      return .performed
+    case .deadlineExceeded:
+      return nil
+    case .failed:
       return .unsupported(
         message: message as String? ?? "private XCTest event synthesis failed",
         hint: "Falling back to XCTest coordinate tap may be slower and can still need a healthy accessibility tree."
       )
+    @unknown default:
+      return .unsupported(
+        message: "private XCTest event synthesis returned an unknown status",
+        hint: "Inspect the current app before deciding whether to act again."
+      )
     }
-    return .performed
 #elseif os(tvOS)
     return .unsupported(
       message: "coordinate tap is not supported on tvOS; move focus with swipe or scroll, then select the focused element",

apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/UnitTests/RunnerTests+SynthesizedGesturePolicyTests.swift

@@ -106,6 +106,17 @@ extension RunnerTests {
     XCTAssertNil(synthesizedPolicyKind(forSequenceStep: sequenceStep("longPress", synthesized: true)))
   }
 
+  @MainActor
+  func testCoordinateTapThatWasNotDispatchedDoesNotFallBackToXCTest() {
+    for health: RunnerAccessibilityHealth in [.unknown, .healthy, .unavailable] {
+      mainOwned.accessibilityHealth = health
+      for context in [nil, synthesizedGestureTestContext(accessibilityHealth: health)] {
+        let attempt = performSynthesizedGesture(app, kind: .coordinateTap, context: context) { nil }
+        XCTAssertEqual(synthesizedGestureRoute(attempt), "refused", "axHealth=\(health.rawValue)")
+      }
+    }
+  }
+
   @MainActor
   func testFailedCoordinateTapSynthesisFallsBackToXCTestAtEveryAccessibilityHealth() {
     for health: RunnerAccessibilityHealth in [.unknown, .healthy, .unavailable] {