refactor: dissolve caller-side replay ownership

Author: thymikee

docs/adr/0018-unified-event-journal.md

@@ -72,7 +72,7 @@ redaction discipline, and sink (inventoried 2026-07-24):
    request via `meta.requestProgress`; disabled under `--json`. Events are written to the wire
    **unredacted** today.
 4. **Replay timing trace** (`src/daemon/handlers/session-replay-trace.ts`,
-   `session-test-runtime.ts`, read by `src/replay/test/trace.ts`). Per-**attempt**
+   `session-test-runtime.ts`, read by `src/cli/replay-test/trace.ts`). Per-**attempt**
    `replay-timing.ndjson` files whose paths are created dynamically inside each attempt — written
    by **two different helpers, one of which redacts and one of which does not**
    (`appendReplayTraceEvent` vs `appendReplayTestTimingEvent`).

docs/adr/0020-composable-recorded-fragments.md

@@ -562,7 +562,7 @@ violation before the production change is trusted.
 
 The audited seam tests are `packages/ad-script/src/internal/__tests__/script.test.ts`,
 `packages/ad-replay/src/internal/__tests__/plan-digest.test.ts`,
-`src/replay/__tests__/script-source-bundle.test.ts`, and
+`src/commands/replay/script-source-bundle.test.ts`, and
 `packages/maestro/src/internal/__tests__/replay-plan.test.ts`,
 `source-closure.test.ts`, `program-loader.test.ts`,
 `src/daemon/handlers/__tests__/session-replay-runtime.test.ts`. The planted-red checks below are

fallow-baselines/health.json

@@ -604,7 +604,7 @@
     "packages/provider-webdriver/src/webdriver-utils.ts:high impact",
     "src/utils/keyed-lock.ts:high impact",
     "src/daemon/request-progress-protocol.ts:high impact",
-    "src/replay/test/reporters/format.ts:high impact",
+    "src/cli/replay-test/reporters/format.ts:high impact",
     "src/daemon/handlers/session-test-infrastructure.ts:high impact",
     "src/daemon/handlers/session-test-artifacts.ts:high impact",
     "packages/platform-android/src/app-parsers.ts:high impact",

packages/ad-script/src/internal/__tests__/script.test.ts

@@ -680,7 +680,7 @@ test('formatDivergenceActionLabel categorically drops fill/type text but keeps t
 });
 
 // The property test asserting "serializing a parsed script is a fixed point
-// for generated scripts" stays at `src/replay/__tests__/ad-script-round-trip.test.ts`:
+// for generated scripts" stays at `src/commands/replay/ad-script-round-trip.test.ts`:
 // its script generator (`replayScriptArb`) is derived from the root command
 // catalog and selector grammar (`src/__tests__/test-utils/property-arbitraries.ts`),
 // which this package cannot import without an R11 package→root-src escape

packages/ad-script/src/internal/target-annotation-identity.ts

@@ -3,9 +3,8 @@
  * prefix matching over versioned `.ad` target-binding evidence, plus the
  * bounded diagnostic diffs built on top of it. Both the writer (over
  * `SnapshotNode`-derived values, `src/daemon/session-target-evidence.ts`) and
- * replay-time verification (`src/daemon/handlers/session-replay-target-classification.ts`,
- * `src/commands/interaction/runtime/selector-wait.ts`, and the shared
- * replay-zone tree helpers in `src/replay/`) share this verbatim so both
+ * replay-time verification (`src/daemon/handlers/session-replay-target-classification.ts` and
+ * `src/commands/interaction/runtime/selector-wait.ts`) share this verbatim so both
  * sides compute the SAME identity/ancestry match by construction (#1478 P5
  * review, "genuinely shared recording vocabulary" relocated to its owner).
  *

scripts/layering/check.ts

@@ -100,6 +100,7 @@ import { listTrackedProductionSources, listTrackedTypeScriptFiles } from './trac
 import { runtimeExecutionIntegrityViolations } from './runtime-execution-policy.ts';
 import { sourceExecutionCompatibilityViolations } from './source-execution-policy.ts';
 import { sessionResourceOwnershipViolations } from './session-resource-ownership.ts';
+import { replayOwnershipViolations } from './replay-ownership.ts';
 import { applicationLifecycleOwnershipViolations } from './application-lifecycle-policy.ts';
 
 const repoRoot = execFileSync('git', ['rev-parse', '--show-toplevel'], {
@@ -547,6 +548,7 @@ export const LAYERING_RULE_IDS = [
   'package-boundaries',
   'platform-package-policy',
   'platforms-root-shape',
+  'replay-ownership',
 ] as const;
 
 export type LayeringRuleId = (typeof LAYERING_RULE_IDS)[number];
@@ -586,6 +588,7 @@ export const LAYERING_RULES: Readonly<Record<LayeringRuleId, LayeringRule>> = {
     ),
   'platforms-root-shape': (context) =>
     checkPlatformsRootShape([...context.allTypeScriptSources.keys()]),
+  'replay-ownership': (context) => replayOwnershipViolations(context.sourceFiles),
 };
 
 export function main(): number {

scripts/layering/daemon-modularity.test.ts

@@ -118,12 +118,15 @@ test('replay-test rejects request-global and engine-internal imports', () => {
         'packages/replay-test/src/internal/scheduler.ts',
         [
           "import { emitRequestProgress } from '../../../../src/request/progress.ts';",
-          "import { readReplayScriptMetadata } from '../../../../src/replay/script.ts';",
+          "import { readReplayScriptMetadata } from '../../../../src/daemon/handlers/session-replay-runtime.ts';",
           "import { parseMaestroProgram } from '../../../../src/compat/maestro/program-ir-parser.ts';",
         ].join('\n'),
       ],
       ['src/request/progress.ts', 'export function emitRequestProgress() {}'],
-      ['src/replay/script.ts', 'export function readReplayScriptMetadata() {}'],
+      [
+        'src/daemon/handlers/session-replay-runtime.ts',
+        'export function readReplayScriptMetadata() {}',
+      ],
       ['src/compat/maestro/program-ir-parser.ts', 'export function parseMaestroProgram() {}'],
     ]),
   );
@@ -136,7 +139,7 @@ test('replay-test rejects request-global and engine-internal imports', () => {
     violations.map(({ message }) => message.replace(/;.*/, '')),
     [
       'replay-test must not import src/request/progress.ts',
-      'replay-test must not import src/replay/script.ts',
+      'replay-test must not import src/daemon/handlers/session-replay-runtime.ts',
       'replay-test must not import src/compat/maestro/program-ir-parser.ts',
     ],
   );

scripts/layering/daemon-modularity.ts

@@ -74,7 +74,6 @@ export const LOGICAL_MODULE_POLICIES: readonly LogicalModulePolicy[] = [
       'src/platforms/',
       'src/providers/',
       'src/request/',
-      'src/replay/',
       'src/compat/',
       'packages/maestro/',
       'packages/ad-replay/',
@@ -85,7 +84,6 @@ export const LOGICAL_MODULE_POLICIES: readonly LogicalModulePolicy[] = [
 const ENGINE_FILE_PREFIXES = [
   'packages/ad-replay/src/',
   'packages/maestro/src/',
-  'src/replay/',
   'src/daemon/handlers/session-replay',
   'packages/replay-test/src/',
 ] as const;
@@ -241,8 +239,7 @@ function checkLogicalModuleImports(edges: readonly ResolvedImportEdge[]): Layeri
     }
 
     if (!sourceModule) continue;
-    // A module's own files are never a forbidden target: `replay-test` sits inside the wider
-    // `src/replay/` engine root it may not import from.
+    // A module's own files are never a forbidden target.
     if (sourceModule.roots.some((root) => edge.target.startsWith(root))) continue;
     if (!sourceModule.forbiddenTargetRoots.some((root) => edge.target.startsWith(root))) continue;
     violations.push({

scripts/layering/model.ts

@@ -36,7 +36,6 @@ const TARGET_DAG_RANK = new Map([
   ['contracts', 1],
   ['maestro', 1],
   ['recording', 1],
-  ['replay', 1],
   ['replay-test', 1],
   ['request', 1],
   ['screenshot-diff', 1],

scripts/layering/replay-ownership.test.ts

@@ -0,0 +1,29 @@
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { REPLAY_OWNERSHIP_RULE, replayOwnershipViolations } from './replay-ownership.ts';
+
+test('R71 rejects a planted production file under retired src/replay by name', () => {
+  const violations = replayOwnershipViolations(['src/replay/planted-production-file.ts']);
+
+  assert.deepEqual(violations, [
+    {
+      rule: REPLAY_OWNERSHIP_RULE,
+      file: 'src/replay/planted-production-file.ts',
+      line: 1,
+      message:
+        'src/replay/ is retired; caller source acquisition belongs under src/commands/replay/ ' +
+        'and replay-test presentation belongs under src/cli/replay-test/.',
+    },
+  ]);
+});
+
+test('R71 accepts the current replay owners', () => {
+  assert.deepEqual(
+    replayOwnershipViolations([
+      'src/commands/replay/script-source-bundle.ts',
+      'src/cli/replay-test/reporting.ts',
+      'src/daemon/replay-script-source.ts',
+    ]),
+    [],
+  );
+});