test(gates): state where the isolation canary compiles and drop the duplicate line-count test

Author: thymikee

scripts/__tests__/runner-isolation-diagnostics.test.ts

@@ -49,10 +49,6 @@ function log(...lines: string[]): string {
 }
 
 describe('scanRunnerBuildLog', () => {
-  test('the canary marks one line per diagnosed shape', () => {
-    expect(isolationCanaryLines(CANARY_SOURCE)).toHaveLength(4);
-  });
-
   test('a log carrying the baseline warnings and the full canary passes', () => {
     expect(scan(...BASELINE_WARNINGS, ...CANARY_DIAGNOSTICS)).toEqual({
       violations: [],

scripts/package-apple-runner-source.mjs

@@ -28,7 +28,8 @@ const LEGACY_OUTPUT_DIRS = [
 ];
 const SKIPPED_DIR_NAMES = new Set(['.build', '.swiftpm', 'UnitTests', 'xcuserdata']);
 const SKIPPED_ROOT_FILES = new Set(['README.md', 'RUNNER_PROTOCOL.md']);
-// The isolation scan's positive control compiles only in this repo's gate builds.
+// The isolation scan's positive control compiles only in scripts/build-xcuitest-apple.sh builds:
+// the repo gates and the prebuilt release runner. Runners built from this package omit it.
 const SKIPPED_RUNNER_FILE_PATHS = new Set([
   path.join('AgentDeviceRunner', 'AgentDeviceRunnerUITests', 'RunnerIsolationCanary.swift'),
 ]);

src/__tests__/apple-runner-package-source.test.ts

@@ -186,7 +186,7 @@ test('package apple runner source skips the unit-test directory and the isolatio
   assert.equal(
     fs.existsSync(path.join(root, `dist/${uitestsDir}/RunnerIsolationCanary.swift`)),
     false,
-    'the isolation scan canary compiles only in repo gate builds',
+    'the isolation scan canary compiles only in scripts/build-xcuitest-apple.sh builds',
   );
 });