Use roles instead of validators for claim verification

[sentry]

Sometimes while validating a claim we get this error message, this is a performance problem under our contract that we should fix

Sentry Issue: FRONTEND-2KB

deadline exceeded 32720us

[lucca65]

The solution for this is to improve the way we store checks in the blockchain. We currently are using secondary indexes to find claims. According to this issue, this forces the algorithm to loop under the entire table.

If we use scopes, this should not happen anymore as we will only loop on the checks related to a single claim_id.

Considerations:

• Plan out the table migration
• Adapt verifyclaim action to use the migrated table with scopes
• Find a way to fill the test database with junk data so we can know it works as intended before the migration (need to have at least 20k different rows during the loop)

Migration

1. Create a new table checks_new
2. Migrate data from checks to checks_new. This will require us to do batches, because of CPU limitations.
3. Delete all data from checks
4. Migrate back from checks_new to checks
5. Count and validate that the original checks has the same number of rows as the new checks
6. Delete data and table checks_new
7. Adjust contract logic to get scope instead of secondary indexes
8. Use the same loop that counts for existing votes to validate if the verifier has already voted (throw error if yes)

[lucca65]

I'll use this issue to also include some other table improvements, so we can have a better usage of scopes

[lucca65]

Those improvements will include changes to

1. network table, to include community id symbol as scope
2. objectives
3. actions
4. claim

Also, from now on, completed claims will be deleted, as we will have them on block history and on our database, no need to keep it on our tables.

[lucca65]

ok, after some progress into #38, its clear that this will require its own migration and more thought.

The basic idea remains the same: now that we have roles, we can make it so actions require a validation of a certain role, and as an extra validation, these role must have the verify permission/ability.

This will make it so that we don't need to actually check if the user is a validator.

it would be good to also migrate our existing actions and claims to use scopes:

1. Create a new table to hold actions, and it should include a new field: eosio::name validation_role and std::string voting_strategy (could be majority or neutrosophic
2. Migrate actions to be scoped by community, with an objective_id column
3. Remove all data from action_validator as well as the table
4. Migrate data on check table to be scoped by claim_id
5. Remove check data for claims that are already voted till the end
6. ❗ At this point check if we are going to implement neutrosophy, this is a good spot to change votes to include more complex algorithms
7. Change actions verify claim to auto clean checks after approval/rejection
8. Change action archiving to support cancelled state