From 504b1637db39df52a44aa4e9993d57c7fdff98c3 Mon Sep 17 00:00:00 2001 From: Carl Csaposs Date: Mon, 31 Aug 2026 15:19:10 +0200 Subject: [PATCH] breaking(lint_workflows.yaml): Remove actionlint zizmor recommends GitHub's new self-repository workflow syntax (https://docs.zizmor.sh/audits/#self-repository) actionlint has not been updated in a few months & does not recognize the new syntax Thus, zizmor and actionlint conflict Further context: https://github.com/rhysd/actionlint/issues/719 https://github.com/rhysd/actionlint/issues/563 https://github.com/rhysd/actionlint/issues/647 --- .github/actionlint.yaml | 12 --------- .github/workflows/lint_workflows.yaml | 35 +-------------------------- 2 files changed, 1 insertion(+), 46 deletions(-) delete mode 100644 .github/actionlint.yaml diff --git a/.github/actionlint.yaml b/.github/actionlint.yaml deleted file mode 100644 index d350723d..00000000 --- a/.github/actionlint.yaml +++ /dev/null @@ -1,12 +0,0 @@ -self-hosted-runner: - labels: - - large - - xlarge - - two-xlarge - - jammy - -paths: - .github/workflows/**/*.{yml,yaml}: - ignore: - # TODO: Remove when https://github.com/rhysd/actionlint/issues/647 is fixed - - 'property "workflow_sha" is not defined in object type' diff --git a/.github/workflows/lint_workflows.yaml b/.github/workflows/lint_workflows.yaml index 58b6d09a..300c5b8e 100644 --- a/.github/workflows/lint_workflows.yaml +++ b/.github/workflows/lint_workflows.yaml @@ -17,40 +17,7 @@ jobs: with: persist-credentials: false - name: Set up environment - run: | - gh release --repo rhysd/actionlint download --pattern '*_linux_amd64.tar.gz' --output actionlint.tar.gz - gh attestation verify --repo rhysd/actionlint --deny-self-hosted-runners --signer-workflow rhysd/actionlint/.github/workflows/release.yaml actionlint.tar.gz - - # Copied from https://github.com/rhysd/actionlint/blob/main/.github/actionlint-matcher.json - cat << 'EOF' > actionlint-matcher.json - { - "problemMatcher": [ - { - "owner": "actionlint", - "pattern": [ - { - "regexp": "^(?:\\x1b\\[\\d+m)?(.+?)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*: (?:\\x1b\\[\\d+m)*(.+?)(?:\\x1b\\[\\d+m)* \\[(.+?)\\]$", - "file": 1, - "line": 2, - "column": 3, - "message": 4, - "code": 5 - } - ] - } - ] - } - EOF - echo "::add-matcher::actionlint-matcher.json" - - tar xf actionlint.tar.gz - - pipx install zizmor - env: - GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Run actionlint - run: | - ./actionlint -color + run: pipx install zizmor - name: Run zizmor run: zizmor . permissions: