In tox.ini for our example charms we have
[testenv]
...
pass_env =
PYTHONPATH
CHARM_BUILD_DIR
MODEL_SETTINGS
I assume that MODEL_SETTINGS is there to make it easier to pass model config settings to Juju for integration tests. But we don't document this anywhere or read MODEL_SETTINGS in Jubilant etc. So the charmer would have to figure out how to wire up everything themselves.
Is it really a useful placeholder? How about we drop it from the example charms and Charmcraft profiles.
In
tox.inifor our example charms we haveI assume that
MODEL_SETTINGSis there to make it easier to pass model config settings to Juju for integration tests. But we don't document this anywhere or readMODEL_SETTINGSin Jubilant etc. So the charmer would have to figure out how to wire up everything themselves.Is it really a useful placeholder? How about we drop it from the example charms and Charmcraft profiles.