At the moment if a CI step is skipped we still run the check job, but skip the auctal CI checking.
This means if we skip say phpdoc then when looking at results list phpdoc gets a green check, so it looks to be passing when its auctally skipped.
The reasoning for this was to simplify the release checks, as using the raw needs field in GitHub, a step needs to pass to allow it to run, this means if a step was skipped, it wouldn't pass and a release wouldn't happen.
To be able to skip steps properly we need to re-do the logic properly for release stage. This will probably involve saving each CI step result to a variable, and then reading that variable vs the skip variable to figure out if we should do a release. Theres no magic "get all results" variable in GH Actions, so this would need to be added 1 by 1.
At the moment if a CI step is skipped we still run the check job, but skip the auctal CI checking.
This means if we skip say
phpdocthen when looking at results listphpdocgets a green check, so it looks to be passing when its auctally skipped.The reasoning for this was to simplify the release checks, as using the raw
needsfield in GitHub, a step needs to pass to allow it to run, this means if a step was skipped, it wouldn't pass and a release wouldn't happen.To be able to skip steps properly we need to re-do the logic properly for release stage. This will probably involve saving each CI step result to a variable, and then reading that variable vs the skip variable to figure out if we should do a release. Theres no magic "get all results" variable in GH Actions, so this would need to be added 1 by 1.