Advanced Combat Feature

[n1kn4x]

Hi all,
I've been coding up a new feature for BotsHub called "Advanced Combat".
You can get the code from the advanced-combat branch in my fork: https://github.com/n1kn4x/BotsHub/tree/advanced-combat.
Currently I am still changing some minor things, but this version should already work for people to test it.
The goal is that this gets merged into upstream master. Before I create a PR, I wanted to gather some feedback from you :)

In the new Advanced Combat tab, you can configure the behavior of any bot that uses the KillFoesInArea function, as this gets rerouted to AdvancedCombatKillFoesInArea if you enable the feature.
The bot will then decide whether to activate a skill on your skillbar depending on so-called "Conditional Gates". The conditional gates can be defined by the user in the GUI.
For example, I configured my Assasin to activate an offhand attack only when the dagger status of the target is lead attack. Or, to cast a shadow step only when the distance to the target is larger than 500 units.
Through the mechanism of conditional gates, the bot behavior can be finely tuned to many powerful builds.
Now, hopefully, more builds can be played by the bots which should increase the success rate of VQs and their speed. Also, its super fun to watch your bot play like a human :)

[ollsen90]

This is absolutely great, big up!

[caustic-kronos]

Yep, definitely a feature that will fit just right in the Hub !

I don't have feedback right now, I need to think about it and sleep on it a few times, and I will come back to the discussion with feedback and maybe ideas on what it could be or how to improve it.

In any case, thank you for this 🥳

[NorthboundCoder]

This looks amazing! I'm gonna have a play around with it over the next few days and give some further feedback. For the moment, I've just cloned your branch and taken a look at the set up.

I've two items of immediate feedback, if thats alright. I'm not too familar with AutoIts full ins and outs. Still learning a lot of its functionality.

My first point, on the configuration page there is a whole load of information on how to set up the gates. It makes the page a bit 'unwieldly' I feel.

On my screen, it actually fills the whole thing. It might be a better idea to have 'information' pop outs for each type of gate. Would make it easier on the end user I feel.

Secondly, as a test, I put in this:
Combo(1,) to see how it would react without proprly completing the function, when I hit save nothing happens. The page doesn't save, but it also doesn't inform me that I've done something wrong. Not sure if AutoIt has functionality that can cover that though!

Overall though, I'm very excited to try this out

[n1kn4x]

thank you!
I changed the layout of the skill configuration window so the wall of text is reduced.
Now only the conditional gates that can be used for each skill type are explained.
Also, I added a tooltip to the dropdown menu to explain what each skill type is for.
About your second point: I added a warning message when the parsing failed. It includes the reason for the parsing error.

[NorthboundCoder]

Amazing, just pulled your updates and it looks really good :)

Need to play around with some builds now :D

[NorthboundCoder]

Just wondering if theres anything we can add in for a gate under damage skills, such as if Adrenline is at 7 pips, use this skill?

[n1kn4x]

Thanks for testing it! I'll also look at how the wall of text can be improved later :)

[NorthboundCoder]

Thats no worries! I'm very excited as you can tell!

I had some issues this morning but decided to try the Derv Pious Renewal build with these gates and stuff. Below is the JSON for the set up I used.

{
	"enabled": true,
	"skills": {
		"1": {
			"type": "preparation",
			"gates": ""
		},
		"2": {
			"type": "damage",
			"gates": "Combo(1,100)\nCooldown(4000)"
		},
		"3": {
			"type": "damage",
			"gates": "Combo(1,1000)\nCooldown(10000)"
		},
		"4": {
			"type": "damage",
			"gates": "Combo(1,1000)\nCooldown(7000)"
		},
		"5": {
			"type": "damage",
			"gates": "Combo(1,1000)\nCooldown(5000)"
		},
		"6": {
			"type": "none",
			"gates": ""
		},
		"7": {
			"type": "preparation",
			"gates": "Combo(1,10)"
		},
		"8": {
			"type": "preparation",
			"gates": "Cooldown(45000)"
		}
	}
}

And here is the build code:

OgCikysMtdJd9cFgZB+WKGKDCA

What I've found is the bot uses skills 1-5 quite well, 6 is obviously skipped, but it doesn't seem to activate skills 7 or 8 at all in or leading to combat.

Any ideas? And take your time :)

[n1kn4x]

Can you try this:

{
	"enabled": true,
	"skills": {
		"1": {
			"type": "preparation",
			"gates": ""
		},
		"2": {
			"type": "damage",
			"gates": "Combo(1,200)\nCooldown(4000)"
		},
		"3": {
			"type": "damage",
			"gates": "Combo(1,1000)\nCooldown(10000)"
		},
		"4": {
			"type": "damage",
			"gates": "Combo(1,1000)\nCooldown(7000)"
		},
		"5": {
			"type": "damage",
			"gates": "Combo(1,1000)\nCooldown(5000)"
		},
		"6": {
			"type": "none",
			"gates": ""
		},
		"7": {
			"type": "damage",
			"gates": "Combo(1,100)"
		},
		"8": {
			"type": "preparation",
			"gates": "IsNotAffectedBySkill(8)"
		}
	}
}

[NorthboundCoder]

I've to head to work but will try and give it a shot later! Thank you

[n1kn4x]

By the way, from my understanding of the build, you could try to also use NotAffectedBySkill(not, 1) for the skills that need skill 1 on you to activate.
This reads a bit weird and could be changed to RequireAffectedBySkill later - but for now it would be interesting to test if that works :)