Summary
Cancelling a long-running Auto Review can reconcile the durable run row to completed with finding_count: 0, even when the agent progress log already emitted findings and repair summaries.
Evidence
Auto Review run 8d2f06bb-78c1-4111-8dd5-3fa6031d3aac for snapshot 67b0fba238182646a49d829433f3d7f56969876a became stuck/retrying during PR #344 review. Its progress log reported multiple findings, including:
[P1] Limit replay dedupe to the immediately preceding assistant cell
[P1] Respect user turns when deduplicating replayed assistant messages
[P2] Avoid deduping replay on truncated assistant previews
- later
[P2] Scan past the newest assistant cell before skipping replay items
After cancelling the auto-review batch, the durable row in ~/.code/state/review/repo-a093bd7f/auto-review/runs.json became:
status: completed, finding_count: 0, summary_digest: null.
That makes the TUI/ledger imply a clean review even though the agent found actionable issues.
Expected behavior
When an Auto Review is cancelled after findings were discovered, the durable ledger should preserve the findings/summary or mark the run cancelled/lost with an error reason. It should not collapse to a clean completed run.
Acceptance criteria
- Cancelling a reviewing Auto Review preserves any emitted findings in the visible ledger.
- Cancellation status is terminal but not represented as clean success.
- TUI freshness/status text distinguishes cancelled/stuck/retry-limited from clean completed.
Related: #345, PR #344.
Summary
Cancelling a long-running Auto Review can reconcile the durable run row to
completedwithfinding_count: 0, even when the agent progress log already emitted findings and repair summaries.Evidence
Auto Review run
8d2f06bb-78c1-4111-8dd5-3fa6031d3aacfor snapshot67b0fba238182646a49d829433f3d7f56969876abecame stuck/retrying during PR #344 review. Its progress log reported multiple findings, including:[P1] Limit replay dedupe to the immediately preceding assistant cell[P1] Respect user turns when deduplicating replayed assistant messages[P2] Avoid deduping replay on truncated assistant previews[P2] Scan past the newest assistant cell before skipping replay itemsAfter cancelling the
auto-reviewbatch, the durable row in~/.code/state/review/repo-a093bd7f/auto-review/runs.jsonbecame:status: completed,finding_count: 0,summary_digest: null.That makes the TUI/ledger imply a clean review even though the agent found actionable issues.
Expected behavior
When an Auto Review is cancelled after findings were discovered, the durable ledger should preserve the findings/summary or mark the run cancelled/lost with an error reason. It should not collapse to a clean completed run.
Acceptance criteria
Related: #345, PR #344.