Skip to content

Align cm-website provider target evidence #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbusillo merged 1 commit into from
Jun 8, 2026
Merged

Align cm-website provider target evidence #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions import-material/launchplane/seed-imports/catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,7 @@
"context": "cm_website",
"instance": "testing",
"target_id": "__ODOO_CM_WEBSITE_TESTING_DOKPLOY_TARGET_ID__",
"project_name": "odoo",
"target_type": "compose",
"target_name": "odoo-tenant-cm-website-testing",
"domains": ["cm-website-testing.shinycomputers.com"],
Expand Down
57 changes: 51 additions & 6 deletions tests/test_product_onboarding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,13 +1754,20 @@ def test_seed_import_odoo_cm_website_onboarding_manifest_owns_preview_records(
self.assertFalse(policies["prod"].enabled)
self.assertEqual(
[
(target.context, target.instance, target.target_type, target.target_id)
(
target.context,
target.instance,
target.project_name,
target.target_type,
target.target_id,
)
for target in manifest.provider_targets
],
[
(
"cm_website",
"testing",
"odoo",
"compose",
"compose-cm-website-testing",
),
Expand Down Expand Up @@ -1790,11 +1797,7 @@ def test_apply_odoo_product_onboarding_keeps_runtime_identity_health_urls(self)
manifest = ProductOnboardingManifest.model_validate(
_seed_import_manifest(
"odoo-cm-website-product-onboarding",
{
"ODOO_CM_WEBSITE_TESTING_DOKPLOY_TARGET_ID": (
"compose-cm-website-testing"
)
},
{"ODOO_CM_WEBSITE_TESTING_DOKPLOY_TARGET_ID": "compose-cm-website-testing"},
)
)

Expand All @@ -1816,6 +1819,48 @@ def test_apply_odoo_product_onboarding_keeps_runtime_identity_health_urls(self)
],
)

def test_apply_odoo_cm_website_onboarding_accepts_existing_provider_target(
self,
) -> None:
with TemporaryDirectory() as temporary_directory_name:
store = PostgresRecordStore(
database_url=_sqlite_database_url(Path(temporary_directory_name) / "db.sqlite3")
)
store.ensure_schema()
store.write_provider_target_record(
ProviderTargetRecord(
context="cm_website",
instance="testing",
provider_id="dokploy",
target_category="compose",
target_id="compose-cm-website-testing",
display_name="odoo-tenant-cm-website-testing",
provider_target_type="compose",
provider_evidence={"project_name": "odoo"},
updated_at="2026-06-07T14:24:42Z",
source_label="service:dokploy-targets:setup:create-compose",
)
)
manifest = ProductOnboardingManifest.model_validate(
_seed_import_manifest(
"odoo-cm-website-product-onboarding",
{"ODOO_CM_WEBSITE_TESTING_DOKPLOY_TARGET_ID": "compose-cm-website-testing"},
)
)

apply_product_onboarding_manifest(
record_store=store, manifest=manifest, updated_at="2026-06-08T00:00:00Z"
)

provider_target = store.read_provider_target_record(
context_name="cm_website", instance_name="testing"
)
store.close()

self.assertEqual(provider_target.provider_evidence, {"project_name": "odoo"})
self.assertEqual(provider_target.target_id, "compose-cm-website-testing")
self.assertEqual(provider_target.updated_at, "2026-06-08T00:00:00Z")

def test_seed_import_odoo_cm_onboarding_manifest_requires_prod_target_id(self) -> None:
with self.assertRaisesRegex(ValueError, "target requires target_id"):
ProductOnboardingManifest.model_validate(
Expand Down