Skip to content

Commit 7021b16

Browse files
jimleroyerjzbahrai
andauthored
Upgrade db version within devcontainer from pg 11 -> 16 (#2787)
* Upgrade db version within devcontainer from pg 11 -> 16 * update ci versions as well * fix error message --------- Co-authored-by: Jumana Bahrainwala <jzbahrai@uwaterloo.ca>
1 parent b1d7ce6 commit 7021b16

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

.devcontainer/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ services:
2020
- notify-network
2121

2222
db:
23-
image: postgres:11.22-bullseye@sha256:c886a3236b3d11abc302e64309186c90a69b49e53ccff23fd8c8b057b5b4bce9
23+
image: postgres:16.11-bookworm@sha256:a2420e9555e2224583fe84d0bb3f0b967e69354ae3a0be55a9c14e251388c4eb
2424
volumes:
2525
- ./initdb:/docker-entrypoint-initdb.d
2626
restart: always

.github/workflows/test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
runs-on: ubuntu-latest
2424
services:
2525
postgres:
26-
image: postgres:11.22-bullseye@sha256:c886a3236b3d11abc302e64309186c90a69b49e53ccff23fd8c8b057b5b4bce9
26+
image: postgres:16.11-bookworm@sha256:a2420e9555e2224583fe84d0bb3f0b967e69354ae3a0be55a9c14e251388c4eb
2727
env:
2828
POSTGRES_USER: postgres
2929
POSTGRES_PASSWORD: postgres

.github/workflows/test_production_ff.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
runs-on: ubuntu-latest
2727
services:
2828
postgres:
29-
image: postgres:11.22-bullseye@sha256:c886a3236b3d11abc302e64309186c90a69b49e53ccff23fd8c8b057b5b4bce9
29+
image: postgres:16.11-bookworm@sha256:a2420e9555e2224583fe84d0bb3f0b967e69354ae3a0be55a9c14e251388c4eb
3030
env:
3131
POSTGRES_USER: postgres
3232
POSTGRES_PASSWORD: postgres

tests/app/dao/test_services_dao.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -841,7 +841,7 @@ def test_create_service_and_history_is_transactional(notify_db_session):
841841
with pytest.raises(IntegrityError) as excinfo:
842842
dao_create_service(service, user)
843843

844-
assert 'null value in column "name" violates not-null constraint' in str(excinfo.value)
844+
assert 'null value in column "name"' in str(excinfo.value)
845845

846846
assert Service.query.count() == 0
847847
assert Service.get_history_model().query.count() == 0

0 commit comments

Comments
 (0)