Inconsistency

[simonrenger]

Good day,

I am curious to know the reason why you have a inconsistency in your naming you are using snake case and lower Camel case.

Besides this I would recommend to put all your internal implementations in an namespace called internal or detail. Makes reading the code easier.

[ceorron]

Hello Simon

Yes I am using both snake_case (as you put it) and camelCase. Camel case is for free functions. Snake case is for class/structure names/member functions and also the new/delete replacement functions.

This isn't even my usual conventions. It is just what I adopted for this project as it was the most convenient for me. I usual do camelCase for everything. Sometimes with upper case for class names (sometimes not).

It isn't all consistent I'll admit but it does work and the code is pretty easy to read. Yeah breaking it down into internal code (namespace) and external might be a good idea. But I'm finding it not too difficult to read, so I don't plan on breaking it up.

I see you have a custom allocators of your own, any good?
https://github.com/simonrenger/memory-allocators

[simonrenger]

hey,

yes you are raising fair points I just asked out of curiosity, you might want to add this

Yes I am using both snake_case (as you put it) and camelCase. Camel case is for free functions. Snake case is for class/structure names/member functions and also the new/delete replacement functions.

in your read me or as a part of a contribution manual.

The code might be clear for you to read but you are the author for me it was not that clear to follow. At the end of the day I was just curios for the reasoning behind the structure, as learning objective - not more or less.

In regards to the memory allocator its a fork and not my own. I have written some but it cannot be published as open source out of closed source reasons.

Thanks for your responses.

[ceorron]

Thanks, simon. For taking the time to try to read my code.