calledOnceWith usage

[katerina-semikina]

Hi,

In the docs I see that sinon-chai assertion for calledOnceWith is spy.should.always.have.been.calledOnceWith(...args).

In the source code in tests I see that spy.should.have.been.calledOnceWith() is used (without always)

Could you please clarify if always should be used for calledOnceWith assertion?

[43081j]

in this case, it probably doesn't matter if you use always or not. so the docs should probably exclude it

since calledOnceWith implies it was always called with some particular args (as it was only ever called one time), making the always chain redundant

its more for always.calledWith(arg) i imagine

[katerina-semikina]

@43081j agree, it doesn't break anything but looks redundant. I think it's better to remove it if it's not really required. So the docs would be more consistent.
It seems to be a quick change to the docs so if any help needed I could create a PR to the readme.

[43081j]

feel free to create a PR updating the readme 👍

happy to review