From 9c0514160dedb9211d00031fb8669740324906c3 Mon Sep 17 00:00:00 2001 From: Hunsu Date: Sat, 9 May 2015 19:57:15 +0200 Subject: [PATCH 1/2] log headers one by one and status log headers one by one for better reading A REST API can return error code (500, 400 for example) so better not consider that as an error of the rest api --- rester/http.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/rester/http.py b/rester/http.py index 1c8888c..3d0aed7 100644 --- a/rester/http.py +++ b/rester/http.py @@ -26,15 +26,16 @@ def request(self, api_url, method, headers, params, is_raw): payload = {"__raw__": response.text} else: payload = response.json() - - if response.status_code < 300: - emit = self.logger.debug - else: - emit = self.logger.warn - emit('Response Headers: %s', str(response.headers)) + self.logger.debug('Status: %s', response.status_code) + self.log_headers(response.headers) if is_raw: - emit('Response:\n%s\n' + response.text) + self.logger.debug('Response:\n%s\n' + response.text) else: - emit('Response:\n%s\n' + json.dumps(payload, sort_keys=True, indent=2)) + self.logger.debug('Response:\n%s\n', json.dumps(payload, sort_keys=True, indent=2)) return ResponseWrapper(response.status_code, payload, response.headers) + + def log_headers(self, headers): + for header in headers: + self.logger.debug('Header: %s = %s', header, headers[header]) + From 31e34c5348e02aab9bdb961dac36137261cc158f Mon Sep 17 00:00:00 2001 From: Hunsu Date: Sat, 9 May 2015 20:02:44 +0200 Subject: [PATCH 2/2] fixed small error --- rester/http.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rester/http.py b/rester/http.py index 3d0aed7..9a0cc53 100644 --- a/rester/http.py +++ b/rester/http.py @@ -29,7 +29,7 @@ def request(self, api_url, method, headers, params, is_raw): self.logger.debug('Status: %s', response.status_code) self.log_headers(response.headers) if is_raw: - self.logger.debug('Response:\n%s\n' + response.text) + self.logger.debug('Response:\n%s\n', response.text) else: self.logger.debug('Response:\n%s\n', json.dumps(payload, sort_keys=True, indent=2))