From ab289ae76bff2494d6c3bc31f83e57c078fdefd0 Mon Sep 17 00:00:00 2001 From: 17skills Date: Tue, 4 Aug 2026 13:34:50 +0200 Subject: [PATCH 1/2] fix(cli): build_cmd should respect vindex dtype when saving gate vectors larql build calls save_gate_vectors(&output_dir), which hardcodes F32 output regardless of the vindex dtype in the build config. Route the CLI through the existing config-aware save_gate_vectors_with_config() so an f16 vindex gets f16 gate vectors instead of silently doubling their size on disk and diverging from the declared dtype. --- crates/larql-cli/src/commands/extraction/build_cmd.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/larql-cli/src/commands/extraction/build_cmd.rs b/crates/larql-cli/src/commands/extraction/build_cmd.rs index 5a1729d6f..d9eef9768 100644 --- a/crates/larql-cli/src/commands/extraction/build_cmd.rs +++ b/crates/larql-cli/src/commands/extraction/build_cmd.rs @@ -80,7 +80,7 @@ pub fn run(args: BuildArgs) -> Result<(), Box> { eprintln!("\nSaving to {}...", output_dir.display()); - let layer_infos = result.index.save_gate_vectors(&output_dir)?; + let layer_infos = result.index.save_gate_vectors_with_config(&output_dir, &result.config)?; let dm_count = result.index.save_down_meta(&output_dir)?; let mut config = result.config; From 748c0e0944c4d4e8f817022236ef53f0bee94ace Mon Sep 17 00:00:00 2001 From: chrishayuk Date: Thu, 6 Aug 2026 00:41:05 +0100 Subject: [PATCH 2/2] style: rustfmt the save_gate_vectors_with_config call MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Whitespace only, no behaviour change. The longer method name pushed the call past rustfmt's `fn_call_width`, so it wraps into a method chain. This was the sole reason CI was red on all three platforms — Format check failed and every later step was skipped, so the fix itself was never actually compiled or tested by CI. --- crates/larql-cli/src/commands/extraction/build_cmd.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/larql-cli/src/commands/extraction/build_cmd.rs b/crates/larql-cli/src/commands/extraction/build_cmd.rs index d9eef9768..dabd96ad5 100644 --- a/crates/larql-cli/src/commands/extraction/build_cmd.rs +++ b/crates/larql-cli/src/commands/extraction/build_cmd.rs @@ -80,7 +80,9 @@ pub fn run(args: BuildArgs) -> Result<(), Box> { eprintln!("\nSaving to {}...", output_dir.display()); - let layer_infos = result.index.save_gate_vectors_with_config(&output_dir, &result.config)?; + let layer_infos = result + .index + .save_gate_vectors_with_config(&output_dir, &result.config)?; let dm_count = result.index.save_down_meta(&output_dir)?; let mut config = result.config;