From 479626a1c764104c83526dded80c4ced06572270 Mon Sep 17 00:00:00 2001 From: Basuvaraj Kumar Date: Thu, 21 May 2026 15:37:29 +0530 Subject: [PATCH 1/3] moved SELF_JOB_NAME to env --- .github/actions/auto-approve-deployments/action.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/actions/auto-approve-deployments/action.yml b/.github/actions/auto-approve-deployments/action.yml index 4809e09..d5b2db2 100644 --- a/.github/actions/auto-approve-deployments/action.yml +++ b/.github/actions/auto-approve-deployments/action.yml @@ -23,9 +23,10 @@ runs: env: GH_TOKEN: ${{ inputs.github_token }} ENVIRONMENT_ALLOW_LIST: ${{ inputs.environment_allow_list }} + SELF_JOB_NAME: ${{ inputs.self_job_name }} run: | ${{ github.action_path }}/poll-and-approve.ps1 ` -Repo '${{ github.repository }}' ` -RunId ${{ github.run_id }} ` -EnvironmentAllowList ($env:ENVIRONMENT_ALLOW_LIST | ConvertFrom-Json) ` - -SelfJobName '${{ inputs.self_job_name }}' + -SelfJobName $env:SELF_JOB_NAME From ebdf23e2ae789bb1bf862bb5da80bfe9a6befa94 Mon Sep 17 00:00:00 2001 From: Basuvaraj Kumar Date: Thu, 21 May 2026 15:37:53 +0530 Subject: [PATCH 2/3] added nul check --- .github/actions/auto-approve-deployments/poll-and-approve.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/auto-approve-deployments/poll-and-approve.ps1 b/.github/actions/auto-approve-deployments/poll-and-approve.ps1 index 604b35a..743b183 100644 --- a/.github/actions/auto-approve-deployments/poll-and-approve.ps1 +++ b/.github/actions/auto-approve-deployments/poll-and-approve.ps1 @@ -60,7 +60,7 @@ while ($elapsed -lt $MaxWaitSeconds) { } # Approve any pending deployments whose environment name matches the allow list. - $allowedEnvIds = @($pending | Where-Object { $EnvironmentAllowList -contains $_.environment.name } | ForEach-Object { $_.environment.id }) + $allowedEnvIds = @($pending | Where-Object { $_.environment -and $_.environment.name -and ($EnvironmentAllowList -contains $_.environment.name } | ForEach-Object { $_.environment.id }) if ($allowedEnvIds.Count -gt 0) { Write-Host "Approving pending deployments (ids: $($allowedEnvIds -join ','))" From e2cedd0bee649535ca528977260c1a4ee8bab3f4 Mon Sep 17 00:00:00 2001 From: Basuvaraj Kumar Date: Thu, 21 May 2026 15:44:11 +0530 Subject: [PATCH 3/3] nitpic --- .github/actions/auto-approve-deployments/poll-and-approve.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/auto-approve-deployments/poll-and-approve.ps1 b/.github/actions/auto-approve-deployments/poll-and-approve.ps1 index 743b183..b4d89a6 100644 --- a/.github/actions/auto-approve-deployments/poll-and-approve.ps1 +++ b/.github/actions/auto-approve-deployments/poll-and-approve.ps1 @@ -60,7 +60,7 @@ while ($elapsed -lt $MaxWaitSeconds) { } # Approve any pending deployments whose environment name matches the allow list. - $allowedEnvIds = @($pending | Where-Object { $_.environment -and $_.environment.name -and ($EnvironmentAllowList -contains $_.environment.name } | ForEach-Object { $_.environment.id }) + $allowedEnvIds = @($pending | Where-Object { $_.environment -and $_.environment.name -and ($EnvironmentAllowList -contains $_.environment.name) } | ForEach-Object { $_.environment.id }) if ($allowedEnvIds.Count -gt 0) { Write-Host "Approving pending deployments (ids: $($allowedEnvIds -join ','))"