Skip to content

Commit 0834686

Browse files
committed
Rs2Reflection: fix menu action descriptors
d4d0d7a 3d7caa4
1 parent 244ff79 commit 0834686

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/reflection

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/reflection/Rs2Reflection.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ public static void invokeMenu(int param0, int param1, int opcode, int identifier
3232
{
3333
if (menuAction == null)
3434
{
35-
final String MENU_ACTION_DESCRIPTOR_VANILLA = "(IIIIIILjava/lang/String;Ljava/lang/String;III)V";
35+
final String MENU_ACTION_DESCRIPTOR_VANILLA_BYTE_GARBAGE_VALUE = "(IIIIIILjava/lang/String;Ljava/lang/String;IIB)V";
36+
final String MENU_ACTION_DESCRIPTOR_VANILLA_INT_GARBAGE_VALUE = "(IIIIIILjava/lang/String;Ljava/lang/String;III)V";
3637
final String MENU_ACTION_DESCRIPTOR_RUNELITE = "(IILnet/runelite/api/MenuAction;IILjava/lang/String;Ljava/lang/String;)V";
3738

3839
final Class<?> clientClazz = Microbot.getClient().getClass();
@@ -72,9 +73,9 @@ else if (insnNode.getOpcode() == Opcodes.SIPUSH)
7273
}
7374

7475
final MethodInsnNode menuActionVanillaInsn = (MethodInsnNode) insnNode.getNext();
75-
if (!menuActionVanillaInsn.desc.equals(MENU_ACTION_DESCRIPTOR_VANILLA))
76+
if (!menuActionVanillaInsn.desc.equals(MENU_ACTION_DESCRIPTOR_VANILLA_BYTE_GARBAGE_VALUE) && !menuActionVanillaInsn.desc.equals(MENU_ACTION_DESCRIPTOR_VANILLA_INT_GARBAGE_VALUE))
7677
{
77-
throw new RuntimeException("Menu action descriptor vanilla has changed from: " + MENU_ACTION_DESCRIPTOR_VANILLA + " to: " + menuActionVanillaInsn.desc);
78+
throw new RuntimeException("Menu action descriptor vanilla has changed to: " + menuActionVanillaInsn.desc);
7879
}
7980
menuAction = Arrays.stream(Class.forName(menuActionVanillaInsn.owner).getDeclaredMethods())
8081
.filter(m -> m.getName().equals(menuActionVanillaInsn.name))

0 commit comments

Comments
 (0)