From fd004c64e563d01afa04debf5e1a4de4cb579ac4 Mon Sep 17 00:00:00 2001
From: Kevin Kipp <kkipp@cloudflare.com>
Date: Fri, 17 Oct 2025 14:02:54 -0500
Subject: [PATCH] fix linter issues

---
 .eslintignore                     | 10 ++++++++++
 .prettierignore                   |  1 +
 app/hooks/usePulledVideoTrack.tsx |  2 +-
 app/hooks/useRoomHistory.ts       |  2 +-
 app/hooks/useStageManager.ts      |  2 +-
 app/utils/safeReturnUrl.ts        |  1 +
 package.json                      |  2 +-
 7 files changed, 16 insertions(+), 4 deletions(-)
 create mode 100644 .eslintignore

diff --git a/.eslintignore b/.eslintignore
new file mode 100644
index 00000000..b83538c8
--- /dev/null
+++ b/.eslintignore
@@ -0,0 +1,10 @@
+node_modules
+.wrangler
+/.cache
+/build
+/dist
+/public/build
+/.mf
+playwright-report
+test-results
+public/e2ee/
diff --git a/.prettierignore b/.prettierignore
index cc2e65dc..c69e6755 100644
--- a/.prettierignore
+++ b/.prettierignore
@@ -1 +1,2 @@
 public/mockServiceWorker.js
+public/e2ee/wasm-pkg/
diff --git a/app/hooks/usePulledVideoTrack.tsx b/app/hooks/usePulledVideoTrack.tsx
index 7b13ebb9..b00a4c68 100644
--- a/app/hooks/usePulledVideoTrack.tsx
+++ b/app/hooks/usePulledVideoTrack.tsx
@@ -37,7 +37,7 @@ export function usePulledVideoTrack(
 						: of(undefined)
 				)
 			),
-		[partyTracks, trackObject$, preferredRid$]
+		[trackObject$, partyTracks, simulcastEnabled, preferredRid$]
 	)
 	return useObservableAsValue(pulledTrack$)
 }
diff --git a/app/hooks/useRoomHistory.ts b/app/hooks/useRoomHistory.ts
index 9b940386..8b5cd1dc 100644
--- a/app/hooks/useRoomHistory.ts
+++ b/app/hooks/useRoomHistory.ts
@@ -44,7 +44,7 @@ export function useRoomHistory(
 		return () => {
 			partyTracks.history.removeEventListener('logentry', handleHistory)
 		}
-	}, [partyTracks, sessionId])
+	}, [partyTracks, room.websocket, sessionId])
 
 	useEffect(() => {
 		room.otherUsers.forEach((user) => {
diff --git a/app/hooks/useStageManager.ts b/app/hooks/useStageManager.ts
index 66e2a4de..8a2eb87f 100644
--- a/app/hooks/useStageManager.ts
+++ b/app/hooks/useStageManager.ts
@@ -116,7 +116,7 @@ export default function useStageManager(
 				setPinnedTileIds((ids) => [...ids, user.id])
 			}
 		})
-	}, [newUsers, recordActivity])
+	}, [newUsers, recordActivity, setPinnedTileIds])
 
 	useEffect(() => {
 		setActorsOnStage((actorsAlreadyOnStage) =>
diff --git a/app/utils/safeReturnUrl.ts b/app/utils/safeReturnUrl.ts
index 20b7ef4f..a1b28b7b 100644
--- a/app/utils/safeReturnUrl.ts
+++ b/app/utils/safeReturnUrl.ts
@@ -2,6 +2,7 @@ import { redirect } from '@remix-run/cloudflare'
 
 export function safeRedirect(url: string, init?: number | ResponseInit) {
 	if (
+		// eslint-disable-next-line no-script-url
 		['javascript:', 'data:', 'vbscript:'].some((str) =>
 			decodeURI(url).trim().toLowerCase().startsWith(str)
 		)
diff --git a/package.json b/package.json
index d7674435..17e238be 100644
--- a/package.json
+++ b/package.json
@@ -3,7 +3,7 @@
 	"scripts": {
 		"build": "remix build",
 		"build:e2ee-worker": "./rust-mls-worker/build.sh",
-		"lint": "prettier --check . && eslint --ignore-path .gitignore --cache --cache-location ./node_modules/.cache/eslint --max-warnings=0 .",
+		"lint": "prettier --check . && eslint --cache --cache-location ./node_modules/.cache/eslint --max-warnings=0 .",
 		"dev": "remix dev --manual -c \"npm start\"",
 		"start": "wrangler dev ./build/index.js ${WRANGLER_ARGS:-}",
 		"prebuild": "npm run clean",