Skip to content
This repository was archived by the owner on Aug 12, 2022. It is now read-only.
This repository was archived by the owner on Aug 12, 2022. It is now read-only.

feat(resolvers): Consider changing IPNetResolver to not return an error for empty strings #327

@erezrokah

Description

@erezrokah

Currently the IPNetResolver returns an error for empty strings. The GCP providers ignore those in specific cases, see https://github.com/cloudquery/cq-provider-gcp/blob/49238085984bc25468ced7484761a3ceb1b7a99e/client/error.go#L59
and https://github.com/cloudquery/cq-provider-gcp/blob/8db6d1e043aec6b17f1f30afc3a0cb551595e34e/resources/services/kubernetes/clusters.go#L145

Ignoring empty strings could be a good default for other providers too, so we should consider it.

The relevant code to update is here

func IPNetResolver(path string) ColumnResolver {

We should first see if other providers experience the same issue as the GCP one

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions