Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Commit e4bd4df

Browse files
fix: new ta task flake processing (#1221)
1 parent 9e8d580 commit e4bd4df

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

tasks/process_flakes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def run_impl(
9494
process_func(repo_id, commit_sha.decode())
9595

9696
except LockError:
97-
log.warning("Unable to acquire process flakeslock for key %s.", lock_name)
97+
log.warning("Unable to acquire process flakes lock for key %s.", lock_name)
9898
return {"successful": False}
9999

100100
return {"successful": True}

tasks/test_results_finisher.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
read_failures_summary,
2727
read_tests_totals_summary,
2828
)
29+
from services.test_analytics.ta_process_flakes import KEY_NAME
2930
from services.test_results import (
3031
FinisherResult,
3132
FlakeInfo,
@@ -143,7 +144,7 @@ def old_impl(
143144
commit: Commit,
144145
chain_result: bool,
145146
commit_yaml: UserYaml,
146-
impl_type: Literal["old", "both", "new"],
147+
impl_type: Literal["old", "both"],
147148
) -> FinisherResult:
148149
repoid = repo.repoid
149150
commitid = commit.commitid
@@ -152,6 +153,8 @@ def old_impl(
152153
if should_do_flaky_detection(repo, commit_yaml):
153154
if commit.merged is True or commit.branch == repo.branch:
154155
redis_client.lpush(NEW_KEY.format(repo.repoid), commit.commitid)
156+
if impl_type == "both":
157+
redis_client.lpush(KEY_NAME.format(repo.repoid), commit.commitid)
155158
self.app.tasks[process_flakes_task_name].apply_async(
156159
kwargs=dict(
157160
repo_id=repoid,

0 commit comments

Comments
 (0)