Some tests run with ./jake.sh test have confusing error messages that make it difficult to tell what the correct formatting is. Such as:
Font weight should be 700: expected '700' to equal 'bold'
(Message - should be 700: actual is 700, expected to be bold?)
It looks like there are a whole sections of tests that have either the wrong expected value or
the wrong error message.
Examples:
|
it('has correct font-weight', function () { |
|
assert.equal(h1.getRawStyle('font-weight'), 'bold', 'Font weight should be 700'); |
|
assert.equal(h2.getRawStyle('font-weight'), 'bold', 'Font weight should be 700'); |
|
assert.equal(h3.getRawStyle('font-weight'), 'bold', 'Font weight should be 700'); |
|
assert.equal(h4.getRawStyle('font-weight'), 'bold', 'Font weight should be 700'); |
|
assert.equal(h5.getRawStyle('font-weight'), 'bold', 'Font weight should be 700'); |
|
assert.equal(h6.getRawStyle('font-weight'), 'normal', 'Font weight should be 400'); |
|
assert.equal(lead.getRawStyle('font-family'), 'Merriweather, georgia', 'Lead font should be Source Sans Pro'); |
Some tests run with
./jake.sh testhave confusing error messages that make it difficult to tell what the correct formatting is. Such as:Font weight should be 700: expected '700' to equal 'bold'(Message - should be 700: actual is 700, expected to be bold?)
It looks like there are a whole sections of tests that have either the wrong expected value or
the wrong error message.
Examples:
uswds-bootstrap/test/specs/css/typography.js
Lines 125 to 131 in d3d38f5
uswds-bootstrap/test/specs/css/typography.js
Line 120 in d3d38f5