You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I opened PR #52 to address the rugguard.py release/download regression from #7.
On reflection, I am not sure the PR is pointed at the right product decision yet. It restores a scripts/rugguard.py shim and adds that file to the GitHub Release assets, which helps repo-checkout usage and keeps current tests/imports working. But if the release asset is downloaded by itself, the shim still depends on the package modules being present, so it does not fully honor the README's advertised path:
The package refactor is cleaner for maintainability.
Avoids carrying a generated/bundled single-file artifact.
Tradeoff:
Weakens the project's current trust/auditability story. The README currently says the source is a single auditable Python file and the direct release download is a no-install path.
Option B: preserve the single-file trust surface
Keep the README promise and make rugguard.py a real standalone release artifact again.
Suggested direction:
Generate or maintain a standalone rugguard.py that works when downloaded alone.
Attach that real standalone file to GitHub Releases.
Add a release/CI check that copies only rugguard.py into a temp directory and runs:
python3 rugguard.py --help
Optionally also smoke-test a known mint, though live public RPC may be flaky:
Context
I opened PR #52 to address the
rugguard.pyrelease/download regression from #7.On reflection, I am not sure the PR is pointed at the right product decision yet. It restores a
scripts/rugguard.pyshim and adds that file to the GitHub Release assets, which helps repo-checkout usage and keeps current tests/imports working. But if the release asset is downloaded by itself, the shim still depends on the package modules being present, so it does not fully honor the README's advertised path:That leaves a choice about the intended pre-1.0 contract.
Option A: package-first pre-1.0
Treat
solana-rugas a normal Python package/CLI project and remove or revise the single-file release promise.Suggested direction:
releases/latest/download/rugguard.pyinstall path from README/site docs.rugguard.pyas a standalone release artifact.pip install solana-rugsolana-rug token ...python3 scripts/solana-rug.py ...from a checkoutWhy this may be right:
Tradeoff:
Option B: preserve the single-file trust surface
Keep the README promise and make
rugguard.pya real standalone release artifact again.Suggested direction:
rugguard.pythat works when downloaded alone.rugguard.pyinto a temp directory and runs:Optionally also smoke-test a known mint, though live public RPC may be flaky:
Why this may be right:
Tradeoff:
Question
Which contract do you want for pre-1.0?
rugguard.pydownload promise and require the release artifact to work standalone.Once you choose, I can update or withdraw PR #52 accordingly instead of silently locking in the wrong compatibility surface.