Git commit: one client per directory (191)

qmdiServer was not supporting remote protocols. This prevents the
PluginManager finding the correct client when asking for commits of a
specific dir.

Now commit form is allocated in a single place and fixes having several
commit forms in the UI.

closes #191

Author: diegoiast

CMakeLists.txt

@@ -62,7 +62,7 @@ else()
     include(cmake/CPM.cmake)
     include(cmake/icons-breeze.cmake)
 
-    CPMAddPackage("gh:diegoiast/qmdilib#24daf747078184577cb379d945b0b85256d7777a")
+    CPMAddPackage("gh:diegoiast/qmdilib#1cd56fd0a955ca59e86f4834f3019639f9c22808")
     CPMAddPackage("gh:diegoiast/qutepart-cpp#eec2e9ae5b50b591f017296ee743ee2860a280e4")
     CPMAddPackage("gh:diegoiast/command-palette-widget#69eb447b61c9d042394a1404c71a0d0b54ac28c0")
     CPMAddPackage("gh:diegoiast/KodoTerm#9d016815076a451ad639fa021d46602585e91247")

src/plugins/git/CommitForm.hpp

@@ -201,7 +201,7 @@ qmdiClient *GitPlugin::openFile(const QString &fileName, int, int, int) {
     auto manager = getManager();
     auto commitForm = new CommitForm(repoDir, this, manager);
     mdiServer->addClient(commitForm);
-    return nullptr;
+    return commitForm;
 }
 
 void GitPlugin::logFileHandler() {
@@ -418,14 +418,14 @@ void GitPlugin::commitHandler() {
         return;
     }
 
-    detectRepoRoot(filename).then(this, [this, manager](const std::tuple<QString, int> &res) {
+    detectRepoRoot(filename).then(this, [manager](const std::tuple<QString, int> &res) {
         auto [repoRoot, exitCode] = res;
         if (exitCode != 0 || repoRoot.isEmpty()) {
             qDebug() << "Filename is not in any git repo";
             return;
         }
-        auto commitForm = new CommitForm(repoRoot, this, manager);
-        mdiServer->addClient(commitForm);
+        auto url = QString("git:" + repoRoot);
+        manager->openFile(url);
     });
 }