fix: Test and type fixes

Author: kevinwang5658

src/commands/login.ts

@@ -4,6 +4,7 @@ import chalk from 'chalk';
 import { BaseCommand } from '../common/base-command.js';
 import { LoginOrchestrator } from '../orchestrators/login.js';
 
+// @ts-ignore
 export default class Login extends BaseCommand {
   static description =
     `Logins to Codify cloud account. 

src/connect/http-routes/handlers/import-handler.ts

@@ -37,7 +37,7 @@ export function importHandler() {
       throw new Error('Invalid codify config');
     }
 
-    const tmpDir = await fs.mkdtemp(os.tmpdir());
+    const tmpDir = await fs.mkdtemp(os.tmpdir() + '/');
     const filePath = path.join(tmpDir, 'codify.jsonc');
     await fs.writeFile(filePath, JSON.stringify(codifyConfig, null, 2));
     session.additionalData.filePath = filePath;

src/connect/http-server.ts

@@ -76,7 +76,7 @@ function listen(app: express.Application, reporter: Reporter, onOpen: (server: S
 }
 
 function createAuthHandler(connectionCode: string) {
-  return (req, res, next) => {
+  return (req: any, res: any, next: any) => {
     if (req.header('Authorization') !== connectionCode) {
       return res.status(400).json({ error: 'Invalid authorization' })
     }
@@ -85,7 +85,7 @@ function createAuthHandler(connectionCode: string) {
   }
 }
 
-function errorHandler(err, req, res, next) {
+function errorHandler(err: Error, req: any, res: any, next: any) {
   console.log(err.message);
   res.status(500).json({ error: err.message });
 }

src/orchestrators/login.ts

@@ -48,8 +48,8 @@ export class LoginOrchestrator {
     try {
       const accessToken = await DashboardApiClient.login(username, password);
       await LoginHelper.save(accessToken);
-    } catch (e) {
-      console.error(chalk.red(JSON.parse(e.message).error));
+    } catch (error: any) {
+      console.error(chalk.red(JSON.parse(error.message).error));
 
       process.exit(1);
     }

test/orchestrator/connect/connect-command.test.ts

@@ -44,6 +44,8 @@ describe('Connect orchestrator tests', () => {
     const reporter = new MockReporter();
     await fakeLogin();
 
+    config.connectServerPort = Math.floor(Math.random() * 10000)
+
     const openSpy = vi.spyOn(open, 'default');
 
     await new Promise<void>((done) => {
@@ -64,7 +66,7 @@ describe('Connect orchestrator tests', () => {
     await fakeLogout();
 
     const loginRunSpy = vi.spyOn(LoginOrchestrator, 'run');
-    const openSpy = vi.spyOn(open, 'default');
+    config.connectServerPort = Math.floor(Math.random() * 10000)
 
     await new Promise<void>((done) => {
       ConnectOrchestrator.run('codify', reporter, false, async (connectionCode: string, server: Server) => {

test/orchestrator/connect/socket-server.test.ts

@@ -239,6 +239,7 @@ describe('Connect orchestrator tests', () => {
           })
         });
 
+        console.log(await commandResponse.text());
         expect(commandResponse.ok).to.be.true;
 
         server.close();
@@ -362,6 +363,8 @@ describe('Connect orchestrator tests', () => {
   })
 
   function startServer(reporter: Reporter, onOpen: (connectionCode: string, clientId: string, server: Server) => void) {
+    config.connectServerPort = Math.floor(Math.random() * 10000)
+
     ConnectOrchestrator.run('codify', reporter, false, async (connectionCode: string, server: Server) => {
       expect(connectionCode).to.be.a('string');
 

test/orchestrator/edit/edit.test.ts

@@ -50,6 +50,8 @@ describe('Edit orchestrator tests', () => {
 
     await expect.poll(async () => {
       return checkPortStatus(config.connectServerPort);
+    }, {
+      timeout: 4000,
     }).toBeTruthy()
   });