Skip to content

Nethermind Execution Update Script Broken (Fix Included) #186

@iLLNESS

Description

@iLLNESS

Not sure when this started, but the execution_update.sh script is not working as is for Nethermind updates due to some extra files not being stripped from the curl command.

curl -s https://api.github.com/repos/NethermindEth/nethermind/releases/latest | jq -r ".assets[] | select(.name) | .browser_download_url" | grep --ignore-case "linux"-"x64"

returns:
https://github.com/NethermindEth/nethermind/releases/download/1.35.8/nethermind-1.35.8-c066aee2-linux-x64.zip
https://github.com/NethermindEth/nethermind/releases/download/1.35.8/nethermind-1.35.8-c066aee2-linux-x64.zip.asc

The wget command then uses both lines returned from the curl command which throws an error.

A fix is to edit the BINARIES_URL line to include an inverse grep that removes all extensions except .zip:
BINARIES_URL=$(curl -s "$RELEASE_URL" | jq -r ".assets[] | select(.name) | .browser_download_url" | grep --ignore-case "${_platform}"-"${_architecture}" | grep -E "\.zip$")

I'm not sure why they included the .asc file as it hasn't been included with previous releases and appears to be a PGP signature for the file. This may be something worthwhile to use for all BINARIES_URL instances just in case other devs start adding stuff similar to what happened with Nethermind.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions