fix: exclude undefined from TypedRun/TypedClientRun output default type#145
Conversation
Change TOutput default from `Record<string, unknown> | undefined` to `Record<string, unknown>` so that `output` is `TOutput | null` without an unnecessary `undefined` union member. Closes #142 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthrough
Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Also remove redundant comments in type tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
TypedRun/TypedClientRun/UseRunsResult/UseRunsClientResultのTOutputデフォルト値からundefinedを除外outputがRecord<string, unknown> | nullになり、不要なundefinedチェックが不要にCloses #142
🤖 Generated with Claude Code
Summary by CodeRabbit
リリースノート
型定義の最適化
テスト追加