fix: escape spec-review loop + skip CI on non-code PRs#178
Merged
Conversation
The spec-review loop monitor's unproductive condition was routing back to spec-review, creating a potential infinite loop (only stopped by max_movements). Now routes to implement so remaining suggestion-level issues don't block progress. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
📝 WalkthroughウォークスルーこのPRは2つのファイルを修正しています。CI ワークフローの 変更箇所
コード レビュー工数🎯 2 (Simple) | ⏱️ ~10 分 関連する可能性のあるPR
詩
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add paths-ignore to pull_request trigger so documentation-only, workflow config, and markdown changes don't spin up PostgreSQL containers and Playwright browsers unnecessarily. Push to main still runs unconditionally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
coji
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
7-14:.takt/**を PR CI から外すなら、軽量検証を別ワークフローで残すのが安全ですLine 11 の除外により、フロー定義変更が自動検知されないままマージされる可能性があります。重いテストを避ける方針は維持しつつ、
.takt/**/.claude/**向けに YAML 構文や最低限の整合性チェックだけ走る軽量ワークフローを追加するのを推奨します。🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yml around lines 7 - 14, The CI config removed '.takt/**' and '.claude/**' via the paths-ignore key, which prevents PR-driven detection of workflow changes; add a separate lightweight workflow that targets those patterns (e.g., triggering on pull_request or push when changes match '.takt/**' or '.claude/**') and runs minimal checks (YAML syntax/lint and basic integrity tests) so workflow definition changes in those directories are still validated; reference the existing paths-ignore setting and create the new workflow to run fast linters (yamllint or GitHub Actions syntax check) for changes touching those patterns.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 7-14: The CI config removed '.takt/**' and '.claude/**' via the
paths-ignore key, which prevents PR-driven detection of workflow changes; add a
separate lightweight workflow that targets those patterns (e.g., triggering on
pull_request or push when changes match '.takt/**' or '.claude/**') and runs
minimal checks (YAML syntax/lint and basic integrity tests) so workflow
definition changes in those directories are still validated; reference the
existing paths-ignore setting and create the new workflow to run fast linters
(yamllint or GitHub Actions syntax check) for changes touching those patterns.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9d68dd3b-f437-4f68-a77f-7e6bcd087e20
📒 Files selected for processing (2)
.github/workflows/ci.yml.takt/pieces/spec-implement-accept.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
implementinstead of back tospec-reviewpaths-ignoreto CI workflow so PRs that only change docs, takt config, or markdown skip testsChanges
takt:
next: spec-review→next: implementfor unproductive loop escapeCI: Skip on PRs that only touch:
*.md,docs/**,website/**.takt/**,.claude/**LICENSE,.gitignorePush to main still runs unconditionally.
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores