Final bug fixes for SHOW TABLES and Table Designer

Author: colloceo

minidb/database.py

@@ -138,6 +138,10 @@ def execute_query(self, query_string):
             parsed = self.parser.parse(query_string)
             cmd_type = parsed['type']
 
+            if cmd_type == 'SHOW_TABLES':
+                table_list = self.get_tables()
+                return [{'table_name': name} for name in table_list]
+
             # Transaction commands
             if cmd_type == 'BEGIN':
                 return self.transaction.begin()
@@ -166,8 +170,9 @@ def execute_query(self, query_string):
                     parsed['right_on']
                 )
 
+            # Commands that require a target table
             table_name = parsed.get('table')
-            if not table_name:
+            if not table_name and cmd_type not in ['BEGIN', 'COMMIT', 'ROLLBACK', 'SHOW_TABLES', 'JOIN']:
                  raise DBError(f"Missing table name for command type {cmd_type}")
 
             if cmd_type == 'CREATE':
@@ -362,9 +367,6 @@ def execute_query(self, query_string):
                     'foreign_keys': table.foreign_keys
                 }
 
-            if cmd_type == 'SHOW_TABLES':
-                table_list = self.get_tables()
-                return [{'table_name': name} for name in table_list]
 
         except (DBError, TypeError) as e:
             return f"Error: {e}"

templates/create_table.html

@@ -290,42 +290,42 @@ <h5 class="modal-title fw-bold text-dark"><i class="fas fa-terminal me-2 text-pr
         fkDiv.id = `fk-${fkCount}`;
 
         // Get available tables
-        const tables = {{ tables | tojson
+        const availableTables = {{ tables | tojson
     }};
 
     fkDiv.innerHTML = `
-        <div class="row g-2 align-items-center">
-            <div class="col-md-3">
-                <label class="form-label small mb-1 fw-bold text-muted">Local Column</label>
-                <select class="form-select form-select-sm" id="fkLocal-${fkCount}">
-                    <option value="">Select column...</option>
-                </select>
-            </div>
-            <div class="col-md-1 text-center pt-3">
-                <i class="fas fa-arrow-right text-muted opacity-50"></i>
-            </div>
-            <div class="col-md-3">
-                <label class="form-label small mb-1 fw-bold text-muted">Ref Table</label>
-                <select class="form-select form-select-sm" id="fkRefTable-${fkCount}" 
-                        onchange="updateRefColumns(${fkCount})">
-                    <option value="">Select table...</option>
-                    ${tables.map(t => `<option value="${t}">${t}</option>`).join('')}
-                </select>
-            </div>
-            <div class="col-md-3">
-                <label class="form-label small mb-1 fw-bold text-muted">Ref Column</label>
-                <select class="form-select form-select-sm" id="fkRefCol-${fkCount}">
-                    <option value="">Select column...</option>
-                </select>
-            </div>
-            <div class="col-md-2 text-end pt-3">
-                <button type="button" class="btn btn-sm btn-remove" 
-                        onclick="removeForeignKey(${fkCount})">
-                    <i class="fas fa-trash"></i>
-                </button>
+            <div class="row g-2 align-items-center">
+                <div class="col-md-3">
+                    <label class="form-label small mb-1 fw-bold text-muted">Local Column</label>
+                    <select class="form-select form-select-sm" id="fkLocal-${fkCount}">
+                        <option value="">Select column...</option>
+                    </select>
+                </div>
+                <div class="col-md-1 text-center pt-3">
+                    <i class="fas fa-arrow-right text-muted opacity-50"></i>
+                </div>
+                <div class="col-md-3">
+                    <label class="form-label small mb-1 fw-bold text-muted">Ref Table</label>
+                    <select class="form-select form-select-sm" id="fkRefTable-${fkCount}" 
+                            onchange="updateRefColumns(${fkCount})">
+                        <option value="">Select table...</option>
+                        ${availableTables.map(t => `<option value="${t}">${t}</option>`).join('')}
+                    </select>
+                </div>
+                <div class="col-md-3">
+                    <label class="form-label small mb-1 fw-bold text-muted">Ref Column</label>
+                    <select class="form-select form-select-sm" id="fkRefCol-${fkCount}">
+                        <option value="">Select column...</option>
+                    </select>
+                </div>
+                <div class="col-md-2 text-end pt-3">
+                    <button type="button" class="btn btn-sm btn-remove" 
+                            onclick="removeForeignKey(${fkCount})">
+                        <i class="fas fa-trash"></i>
+                    </button>
+                </div>
             </div>
-        </div>
-    `;
+        `;
 
     container.appendChild(fkDiv);
     updateLocalColumns(fkCount);