refactor: cleanup

Author: eldomagan

packages/core/src/Data/BlockBuilder.php

@@ -18,18 +18,15 @@ class BlockBuilder extends PresetChild
      */
     public static function forTemplate(string $id, string $type): static
     {
-        // If type is a BlockInterface class, resolve to type string
         if (class_exists($type) && is_subclass_of($type, BlockInterface::class)) {
             $type = $type::type();
         }
 
-        // If type is a BlockPreset class, convert to PresetChild
         if (class_exists($type) && is_subclass_of($type, BlockPreset::class)) {
             /** @var BlockPreset $type */
             return static::fromPresetChild($type::asChild(), $id);
         }
 
-        // Create new instance with type
         $instance = new static($type);
         $instance->id = $id;
 
@@ -44,7 +41,6 @@ public static function fromPresetChild(PresetChild $child, string $id): static
     {
         $instance = new static($child->type);
 
-        // Copy all properties from PresetChild
         $instance->id = $id;
         $instance->name = $child->name;
         $instance->properties = $child->properties;

packages/core/src/Data/BlockPreset.php

@@ -53,10 +53,8 @@ protected function getName(): string
     {
         $class = (new \ReflectionClass(static::class))->getShortName();
 
-        // Remove "Preset" suffix if present
         $class = preg_replace('/Preset$/', '', $class);
 
-        // Convert PascalCase to spaces (e.g., "RichText" -> "Rich Text")
         $words = preg_replace('/(?<!^)[A-Z]/', ' $0', $class);
 
         return trim($words);

packages/core/src/Data/PresetChild.php

@@ -58,10 +58,8 @@ protected function getType(): string
     {
         $class = (new \ReflectionClass(static::class))->getShortName();
 
-        // Remove "PresetChild" or "Child" suffix if present
         $class = preg_replace('/(PresetChild|Child)$/', '', $class);
 
-        // Convert PascalCase to kebab-case (e.g., "Paragraph" -> "paragraph")
         $kebab = strtolower(preg_replace('/(?<!^)[A-Z]/', '-$0', $class));
 
         return $kebab;
@@ -71,10 +69,7 @@ protected function getType(): string
      * Build the preset child configuration.
      * Override this method in subclasses to define structure.
      */
-    protected function build(): void
-    {
-        // Base implementation does nothing
-    }
+    protected function build(): void {}
 
     /**
      * Set the block type.

packages/core/src/Data/Template.php

@@ -34,15 +34,12 @@ public static function make(): static
      */
     public function block(string $id, string $type, ?callable $config = null): static
     {
-        // Create new block using factory
         $block = BlockBuilder::forTemplate($id, $type);
 
-        // Apply configuration callback if provided
         if ($config !== null) {
             $config($block);
         }
 
-        // Add block to template
         $this->blocks[] = $block;
 
         return $this;

packages/core/src/Services/BlockFlattener.php

@@ -88,7 +88,6 @@ protected function extractBlockRecursively(array $blockData, array &$flatBlocks,
 
             $flatBlock['children'] = $uniqueChildIds;
         } elseif (! empty($children) && is_array($children)) {
-            // These are just ID references, keep as-is
             $flatBlock['children'] = $children;
         }
 
@@ -170,13 +169,8 @@ protected function extractChildBlocks($children): array
      */
     protected function sanitizeTypeForId(string $type): string
     {
-        // Remove @ prefix
         $sanitized = ltrim($type, '@');
-
-        // Replace / and - with _
         $sanitized = str_replace(['/', '-'], '_', $sanitized);
-
-        // Convert to snake_case
         $sanitized = strtolower($sanitized);
 
         return $sanitized ?: 'block';

packages/laravel/src/BlockDatastore.php

@@ -28,7 +28,6 @@ public function loadFile(string $sourceFilePath): void
 
         $blocks = $this->getBlocksArray($sourceFilePath);
 
-        // Create BlockData for each block and store in cache
         foreach ($blocks as $blockId => $blockData) {
             $block = Craftile::createBlockData(
                 $blockData,
@@ -124,7 +123,6 @@ public function getBlocksArray(string $sourceFilePath): array
      */
     protected function assignBlockIndices(array &$blocks, array $template): void
     {
-        // Assign indices for blocks in regions
         foreach ($template['regions'] ?? [] as $region) {
             foreach ($region['blocks'] ?? [] as $index => $blockId) {
                 if (isset($blocks[$blockId])) {
@@ -133,7 +131,6 @@ protected function assignBlockIndices(array &$blocks, array $template): void
             }
         }
 
-        // Assign indices for child blocks
         foreach ($blocks as $blockId => $blockData) {
             foreach ($blockData['children'] ?? [] as $index => $childId) {
                 if (isset($blocks[$childId])) {

packages/laravel/src/Support/HandleUpdates.php

@@ -21,7 +21,6 @@ public function __construct(
      */
     public function execute(string $sourceFilePath, UpdateRequest $updateRequest, ?array $targetRegions = null): array
     {
-        // Get fully normalized data from parser's pipeline
         $sourceData = $this->parser->parse($sourceFilePath);
 
         if (! $this->hasUpdates($sourceData, $updateRequest, $targetRegions)) {
@@ -45,13 +44,10 @@ private function applyUpdates(array $data, UpdateRequest $updateRequest, ?array
 
         foreach ($blocksToRemove as $blockId) {
             if (isset($data['blocks'][$blockId])) {
-                // Get all descendants to remove entire subtree
                 $descendants = $this->getAllDescendants($blockId, $data['blocks']);
 
-                // Remove the block itself
                 unset($data['blocks'][$blockId]);
 
-                // Remove all descendants
                 foreach ($descendants as $descendantId) {
                     if (isset($data['blocks'][$descendantId])) {
                         unset($data['blocks'][$descendantId]);

packages/laravel/src/View/WrapperCompiler.php

@@ -23,12 +23,10 @@ class WrapperCompiler
      */
     public static function compileWrapper(string $emmet, string $blockId): array
     {
-        // If emmet doesn't contain __content__, append it
         if (! str_contains($emmet, '__content__')) {
             $emmet .= '{__content__}';
         }
 
-        // Parse the emmet syntax to HTML
         $html = SimpleEmmetParser::parse($emmet);
 
         // Inject data-block attribute into the first tag
@@ -39,7 +37,6 @@ public static function compileWrapper(string $emmet, string $blockId): array
             1
         );
 
-        // Split by __content__ placeholder
         [$opening, $closing] = explode('__content__', $html, 2);
 
         return [$opening, $closing];

tests/core/Services/BlockFlattenerTest.php

@@ -64,13 +64,11 @@
         $blocks = $result['blocks'];
         expect($blocks)->toHaveCount(3); // parent + 2 children
 
-        // Check parent block
         expect($blocks['parent'])->toHaveKey('id', 'parent');
         expect($blocks['parent'])->toHaveKey('type', 'container');
         expect($blocks['parent'])->toHaveKey('children');
         expect($blocks['parent']['children'])->toHaveCount(2);
 
-        // Check children exist
         $childIds = $blocks['parent']['children'];
         expect($blocks)->toHaveKey($childIds[0]);
         expect($blocks)->toHaveKey($childIds[1]);