Skip to content

Refactor require pattern in WorkermanBundle to proper classes #145

@s2x

Description

@s2x

Problem Description

After extracting CompilerPass to a proper class in #144, WorkermanBundle.php still uses require to load configuration files inconsistently.

Current state

public function configure(DefinitionConfigurator $definition): void
{
    $configurator = require __DIR__ . '/config/configuration.php';
    $configurator($definition);
}

public function loadExtension(array $config, ContainerConfigurator $container, ContainerBuilder $builder): void
{
    $configurator = require __DIR__ . '/config/services.php';
    $configurator($config, $builder);
}

Expected

public function configure(DefinitionConfigurator $definition): void
{
    $this->configuration->configure($definition);
}

public function loadExtension(array $config, ContainerConfigurator $container, ContainerBuilder $builder): void
{
    $this->servicesConfigurator->configure($config, $builder);
}

Labels

enhancement, code-quality

Milestone

3

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-qualityCode quality improvementsenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions