Skip to content

Commit 574ef96

Browse files
crazytanclaude
andcommitted
Fix CI code signing and remove redundant tests
- Use CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO for CI builds - Fix test step to use TaskMenu scheme (not TaskMenuTests) - Quote heredoc delimiter to prevent variable expansion - Remove 4 tests from GoogleTasksAPITests duplicated in TaskItemModelTests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 8ffa198 commit 574ef96

File tree

2 files changed

+3
-52
lines changed

2 files changed

+3
-52
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414

1515
- name: Create Config.xcconfig with dummy values
1616
run: |
17-
cat > Config.xcconfig <<EOF
17+
cat > Config.xcconfig <<'EOF'
1818
GOOGLE_CLIENT_ID = dummy-client-id.apps.googleusercontent.com
1919
GOOGLE_CLIENT_SECRET = dummy-client-secret
2020
EOF
@@ -26,7 +26,7 @@ jobs:
2626
run: xcodegen generate
2727

2828
- name: Build
29-
run: xcodebuild build -project TaskMenu.xcodeproj -scheme TaskMenu -destination "platform=macOS" CODE_SIGN_IDENTITY="-" CODE_SIGN_STYLE=Manual DEVELOPMENT_TEAM=""
29+
run: xcodebuild build -project TaskMenu.xcodeproj -scheme TaskMenu -destination "platform=macOS" CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGN_STYLE=Manual DEVELOPMENT_TEAM=""
3030

3131
- name: Test
32-
run: xcodebuild test -project TaskMenu.xcodeproj -scheme TaskMenuTests -destination "platform=macOS" CODE_SIGN_IDENTITY="-" CODE_SIGN_STYLE=Manual DEVELOPMENT_TEAM=""
32+
run: xcodebuild test -project TaskMenu.xcodeproj -scheme TaskMenu -destination "platform=macOS" CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGN_STYLE=Manual DEVELOPMENT_TEAM=""

TaskMenuTests/GoogleTasksAPITests.swift

Lines changed: 0 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,6 @@ final class GoogleTasksAPITests: XCTestCase {
2828
XCTAssertNotNil(task.dueDate)
2929
}
3030

31-
func testDecodeCompletedTask() throws {
32-
let json = """
33-
{
34-
"id": "task2",
35-
"title": "Done task",
36-
"status": "completed"
37-
}
38-
""".data(using: .utf8)!
39-
40-
let task = try JSONDecoder().decode(TaskItem.self, from: json)
41-
XCTAssertEqual(task.status, .completed)
42-
XCTAssertTrue(task.isCompleted)
43-
}
44-
4531
func testDecodeTaskList() throws {
4632
let json = """
4733
{
@@ -99,41 +85,6 @@ final class GoogleTasksAPITests: XCTestCase {
9985
XCTAssertNil(list.items)
10086
}
10187

102-
func testTaskToggle() throws {
103-
let json = """
104-
{"id": "t1", "title": "Test", "status": "needsAction"}
105-
""".data(using: .utf8)!
106-
107-
var task = try JSONDecoder().decode(TaskItem.self, from: json)
108-
XCTAssertFalse(task.isCompleted)
109-
110-
task.isCompleted = true
111-
XCTAssertEqual(task.status, .completed)
112-
113-
task.isCompleted = false
114-
XCTAssertEqual(task.status, .needsAction)
115-
}
116-
117-
func testTaskEncode() throws {
118-
let json = """
119-
{"id": "t1", "title": "Test", "status": "needsAction"}
120-
""".data(using: .utf8)!
121-
122-
let task = try JSONDecoder().decode(TaskItem.self, from: json)
123-
let encoded = try JSONEncoder().encode(task)
124-
let decoded = try JSONDecoder().decode(TaskItem.self, from: encoded)
125-
XCTAssertEqual(decoded.id, "t1")
126-
XCTAssertEqual(decoded.title, "Test")
127-
XCTAssertEqual(decoded.status, .needsAction)
128-
}
129-
130-
// MARK: - TaskStatus Raw Values
131-
132-
func testTaskStatusRawValues() {
133-
XCTAssertEqual(TaskItem.TaskStatus.needsAction.rawValue, "needsAction")
134-
XCTAssertEqual(TaskItem.TaskStatus.completed.rawValue, "completed")
135-
}
136-
13788
// MARK: - dueDate Computed Property
13889

13990
func testDueDateGetReturnsDateWhenDueIsSet() throws {

0 commit comments

Comments
 (0)