You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using Deprecated annotation seems neat, yet while this works, I'm not happy about the fact that deprecated class warnings show up when running specs or building the binary, and I'm not sure yet how to resolve this issue.
Yeah, it feels like this might be at the wrong layer. That's similar to the API docs for the rules, which don't serve as developer documentation, but user documentation.
The distinction here is that using these classes in the Ameba API is not (necessarily) deprecated.
But using the rules in your Ameba configuration is.
Excluding deprecation warnings with --exclude-warnings src/ would be too broad, and there's no fine-grained warning management.
I believe it would easier overall to not use @[Deprecated] annotation. What's the benefit of that anyway?
We could use a custom annotation (@[Ameba::DeprecatedRule]) which would achieve basically the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #765