Skip to content

Commit 1335e37

Browse files
committed
I have refactored the code by:
Extracting the hiding and showing logic into two new helper functions: hideInstantUsagePrompts() and showInstantUsagePrompts(). Replacing all manual manipulations of dom.instantUsagePrompts.classList with calls to these helpers. Simplifying setPhotoImportState and beginPairMode by using the new hideInstantUsagePrompts() helper.
1 parent 5a73275 commit 1335e37

1 file changed

Lines changed: 18 additions & 8 deletions

File tree

src/index.js

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,18 @@ function updateStatusText() {
297297
updateInstantUsagePromptsVisibility();
298298
}
299299

300+
function hideInstantUsagePrompts() {
301+
if (dom.instantUsagePrompts) {
302+
dom.instantUsagePrompts.classList.add('hidden');
303+
}
304+
}
305+
306+
function showInstantUsagePrompts() {
307+
if (dom.instantUsagePrompts) {
308+
dom.instantUsagePrompts.classList.remove('hidden');
309+
}
310+
}
311+
300312
function updateInstantUsagePromptsVisibility() {
301313
if (!dom.instantUsagePrompts) return;
302314

@@ -305,12 +317,12 @@ function updateInstantUsagePromptsVisibility() {
305317
const hasTwoPairs = state.pairs.length >= 2;
306318

307319
if (hasTwoPairs || (hasPairs && hasScale)) {
308-
dom.instantUsagePrompts.classList.add('hidden');
320+
hideInstantUsagePrompts();
309321
return;
310322
}
311323

312324
if (state.imageDataUrl) {
313-
dom.instantUsagePrompts.classList.remove('hidden');
325+
showInstantUsagePrompts();
314326

315327
if (dom.instantSetScaleButton) {
316328
dom.instantSetScaleButton.classList.toggle('hidden', hasScale);
@@ -319,7 +331,7 @@ function updateInstantUsagePromptsVisibility() {
319331
dom.oneTapCalibrateButton.classList.toggle('hidden', hasPairs);
320332
}
321333
} else {
322-
dom.instantUsagePrompts.classList.add('hidden');
334+
hideInstantUsagePrompts();
323335
}
324336
}
325337

@@ -330,8 +342,8 @@ function setPhotoImportState(hasImage) {
330342
if (dom.replacePhotoButton) {
331343
dom.replacePhotoButton.classList.toggle('hidden', !hasImage);
332344
}
333-
if (!hasImage && dom.instantUsagePrompts) {
334-
dom.instantUsagePrompts.classList.add('hidden');
345+
if (!hasImage) {
346+
hideInstantUsagePrompts();
335347
}
336348
}
337349

@@ -603,9 +615,7 @@ function beginPairMode() {
603615
state.activePair = { pixel: null, wgs84: null };
604616

605617
// Hide prompts since we are starting a manual pair
606-
if (dom.instantUsagePrompts) {
607-
dom.instantUsagePrompts.classList.add('hidden');
608-
}
618+
hideInstantUsagePrompts();
609619

610620
clearActivePairMarkers();
611621
updatePairStatus();

0 commit comments

Comments
 (0)