From 0b25271a318f608227f6dfbca1257695928b31ff Mon Sep 17 00:00:00 2001 From: blai Date: Sat, 27 Jun 2026 12:27:44 +0200 Subject: [PATCH] Simplify is_job_done() to a single return statement Replace the verbose if/else block with an equivalent one-liner using `not in`, which is clearer and more Pythonic. --- plugins/module_utils/controller_api.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/plugins/module_utils/controller_api.py b/plugins/module_utils/controller_api.py index 505a6ee..5c538f6 100644 --- a/plugins/module_utils/controller_api.py +++ b/plugins/module_utils/controller_api.py @@ -1036,10 +1036,7 @@ def logout(self): self.warn(f'Failed to release token {self.oauth_token_id}: {e}') def is_job_done(self, job_status): - if job_status in ['new', 'pending', 'waiting', 'running']: - return False - else: - return True + return job_status not in ['new', 'pending', 'waiting', 'running'] def wait_on_url(self, url, object_name, object_type, timeout=30, interval=2): # Grab our start time to compare against for the timeout