Skip to content

Commit 0a22241

Browse files
committed
Merge pull request react-bootstrap#1228 from AlexKVal/v0.26-rc
`v0.26 rc` lift-up
2 parents 757aa97 + 886054d commit 0a22241

3 files changed

Lines changed: 9 additions & 4 deletions

File tree

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@
5555
"css-loader": "^0.16.0",
5656
"es5-shim": "^4.1.10",
5757
"eslint": "^1.1.0",
58-
"eslint-config-airbnb": "0.0.7",
58+
"eslint-config-airbnb": "0.0.8",
5959
"eslint-plugin-babel": "^2.0.0",
6060
"eslint-plugin-lodash": "^0.1.3",
61-
"eslint-plugin-mocha": "^0.4.0",
61+
"eslint-plugin-mocha": "^0.5.1",
6262
"eslint-plugin-react": "^3.1.0",
6363
"express": "^4.13.1",
6464
"extract-text-webpack-plugin": "^0.8.2",

src/MenuItem.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ export default class MenuItem extends React.Component {
4747
<SafeAnchor
4848
role='menuitem'
4949
tabIndex='-1'
50+
id={this.props.id}
5051
target={this.props.target}
5152
title={this.props.title}
5253
href={this.props.href || ''}
@@ -78,7 +79,11 @@ MenuItem.propTypes = {
7879
target: React.PropTypes.string,
7980
title: React.PropTypes.string,
8081
onKeyDown: React.PropTypes.func,
81-
onSelect: React.PropTypes.func
82+
onSelect: React.PropTypes.func,
83+
id: React.PropTypes.oneOfType([
84+
React.PropTypes.string,
85+
React.PropTypes.number
86+
])
8287
};
8388

8489
MenuItem.defaultProps = {

src/utils/CustomPropTypes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const CustomPropTypes = {
4444

4545
isRequiredForA11y(propType){
4646
return function(props, propName, componentName){
47-
if (props[propName] === null) {
47+
if (props[propName] == null) {
4848
return new Error(
4949
'The prop `' + propName + '` is required to make ' + componentName + ' accessible ' +
5050
'for users using assistive technologies such as screen readers `'

0 commit comments

Comments
 (0)