Merge pull request react-bootstrap#1579 from taion/Modal-cleanup

Ensure Modal cleanup

Author: jquense

src/Modal.js

@@ -106,6 +106,10 @@ const Modal = React.createClass({
     };
   },
 
+  componentWillUnmount() {
+    events.off(window, 'resize', this.handleWindowResize);
+  },
+
   render() {
     let {
         className

test/ModalSpec.js

@@ -1,3 +1,4 @@
+import events from 'dom-helpers/events';
 import React from 'react';
 import ReactTestUtils from 'react/lib/ReactTestUtils';
 import ReactDOM from 'react-dom';
@@ -175,4 +176,42 @@ describe('Modal', () => {
       , mountPoint);
   });
 
+  describe('cleanup', () => {
+    let offSpy;
+
+    beforeEach(() => {
+      offSpy = sinon.spy(events, 'off');
+    });
+
+    afterEach(() => {
+      events.off.restore();
+    });
+
+    it('should remove resize listener when unmounted', () => {
+      class Component extends React.Component {
+        constructor(props, context) {
+          super(props, context);
+
+          this.state = {
+            show: true,
+          };
+        }
+
+        render() {
+          if (!this.state.show) {
+            return null;
+          }
+
+          return (
+            <Modal show>Foo</Modal>
+          );
+        }
+      }
+
+      const instance = render(<Component />, mountPoint);
+      instance.setState({ show: false });
+
+      expect(offSpy).to.have.been.calledWith(window, 'resize');
+    });
+  });
 });