fix: manifest file path not shown if parsing failed

Author: cuinixam

bootstrap.ps1

@@ -5,7 +5,7 @@
 
 function Invoke-Bootstrap {
     # Download bootstrap scripts from external repository
-    Invoke-RestMethod https://raw.githubusercontent.com/avengineers/bootstrap-installer/v1.14.2/install.ps1 | Invoke-Expression
+    Invoke-RestMethod https://raw.githubusercontent.com/avengineers/bootstrap-installer/v1.17.0/install.ps1 | Invoke-Expression
     # Execute bootstrap script
     . .\.bootstrap\bootstrap.ps1
 }

src/py_app_dev/core/scoop_wrapper.py

@@ -203,21 +203,25 @@ def parse_env_vars(env_set: Dict[str, str], app_path: Path) -> Dict[str, Any]:
     def parse_manifest_file(self, manifest_file: Path) -> InstalledScoopApp:
         app_directory: Path = manifest_file.parent
         tool_name: str = app_directory.parent.name
-        with open(manifest_file) as f:
-            manifest_data: Dict[str, Any] = json.load(f)
-            tool_version: str = manifest_data.get("version", "")
-            bin_dirs: List[Path] = self.parse_bin_dirs(manifest_data.get("bin", []))
-            env_add_path: List[Path] = self.parse_env_path_dirs(manifest_data.get("env_add_path", []))
-            installed_app = InstalledScoopApp(
-                name=tool_name,
-                version=tool_version,
-                path=app_directory,
-                manifest_file=manifest_file,
-                bin_dirs=bin_dirs,
-                env_add_path=env_add_path,
-                env_vars=self.parse_env_vars(manifest_data.get("env_set", {}), app_directory),
-            )
-            return installed_app
+        try:
+            with open(manifest_file) as f:
+                manifest_data: Dict[str, Any] = json.load(f)
+        except json.JSONDecodeError as e:
+            raise UserNotificationException(f"Failed to parse manifest file: {manifest_file.as_posix()}. Error: {e}") from None
+
+        tool_version: str = manifest_data.get("version", "")
+        bin_dirs: List[Path] = self.parse_bin_dirs(manifest_data.get("bin", []))
+        env_add_path: List[Path] = self.parse_env_path_dirs(manifest_data.get("env_add_path", []))
+        installed_app = InstalledScoopApp(
+            name=tool_name,
+            version=tool_version,
+            path=app_directory,
+            manifest_file=manifest_file,
+            bin_dirs=bin_dirs,
+            env_add_path=env_add_path,
+            env_vars=self.parse_env_vars(manifest_data.get("env_set", {}), app_directory),
+        )
+        return installed_app
 
     def get_installed_apps(self) -> List[InstalledScoopApp]:
         installed_tools: List[InstalledScoopApp] = []

tests/test_scoop_wrapper.py

@@ -525,3 +525,31 @@ def test_bin_dirs_with_root_executable(scoop_dir: Path) -> None:
 
     # Assert the bin_dirs includes the app root directory
     assert installed_app.bin_dirs == [Path(".")], "The app root directory should be included in bin_dirs for root-level executables."
+
+
+def test_parse_manifest_file_invalid_json(scoop_dir: Path) -> None:
+    """Test that parse_manifest_file raises UserNotificationException for invalid JSON."""
+    scoop_wrapper = create_scoop_wrapper(scoop_dir / "scoop.ps1")
+
+    # Create a mock manifest file with invalid JSON
+    manifest_file = scoop_dir / "apps" / "app_with_invalid_json" / "1.0" / "manifest.json"
+    manifest_file.parent.mkdir(parents=True)
+    manifest_file.write_text("{ invalid json }")
+
+    # Assert that UserNotificationException is raised with the correct message
+    with pytest.raises(UserNotificationException, match=f"Failed to parse manifest file: {manifest_file.as_posix()}.*"):
+        scoop_wrapper.parse_manifest_file(manifest_file)
+
+
+def test_parse_manifest_file_invalid_characters(scoop_dir: Path) -> None:
+    """Test that parse_manifest_file raises UserNotificationException for invalid characters."""
+    scoop_wrapper = create_scoop_wrapper(scoop_dir / "scoop.ps1")
+
+    # Create a mock manifest file with invalid characters
+    manifest_file = scoop_dir / "apps" / "app_with_invalid_chars" / "1.0" / "manifest.json"
+    manifest_file.parent.mkdir(parents=True)
+    manifest_file.write_text('\x00\x01\x02{"abc":"val"}')  # Invalid characters
+
+    # Assert that UserNotificationException is raised with the correct message
+    with pytest.raises(UserNotificationException, match=rf"Failed to parse manifest file: {manifest_file.as_posix()}.*"):
+        scoop_wrapper.parse_manifest_file(manifest_file)