I've been running z13ctl on a GZ302EA and noticed the PPT writes go through the old asus_wmi platform path, which the kernel now warns is on its way out.
On kernel 7.1.11 I get this at every boot:
asus_wmi: Accessing attributes through /sys/bus/platform/asus_wmi is deprecated
and will be removed in a future release. Please switch over to
/sys/class/firmware_attributes.
The practical effect today is that the two interfaces disagree. After z13ctl tdp --set 45:
# what z13ctl writes
/sys/devices/platform/asus-nb-wmi/ppt_pl1_spl 45
/sys/devices/platform/asus-nb-wmi/ppt_pl2_sppt 45
/sys/devices/platform/asus-nb-wmi/ppt_fppt 45
# what asus-armoury reports
.../asus-armoury/attributes/ppt_pl1_spl/current_value 60
.../asus-armoury/attributes/ppt_pl2_sppt/current_value 75
.../asus-armoury/attributes/ppt_pl3_fppt/current_value 86
The armoury values are just the firmware defaults and never move. z13ctl's writes do take effect behaviourally, so nothing is broken for me right now, but anything else on the system reading the newer interface sees stale numbers. And once the deprecated path is actually removed, TDP control stops working.
The newer interface looks like a drop-in target. All three attributes are there, current_value is writable (0644), and each one exposes bounds so they don't need hardcoding:
ppt_pl1_spl current=60 default=60 min=28 max=80
ppt_pl2_sppt current=75 default=75 min=32 max=92
ppt_pl3_fppt current=86 default=86 min=45 max=93
One naming gotcha: ppt_fppt on the old path maps to ppt_pl3_fppt on the new one.
Is this already on your radar? Happy to test a branch on a GZ302EA, or put together a PR that prefers /sys/class/firmware-attributes/asus-armoury/ and falls back to the old path when it isn't present.
Versions: z13ctl 1.3.2, kernel 7.1.11, asus_wmi BIOS WMI version 9.4.
I've been running z13ctl on a GZ302EA and noticed the PPT writes go through the old asus_wmi platform path, which the kernel now warns is on its way out.
On kernel 7.1.11 I get this at every boot:
The practical effect today is that the two interfaces disagree. After
z13ctl tdp --set 45:The armoury values are just the firmware defaults and never move. z13ctl's writes do take effect behaviourally, so nothing is broken for me right now, but anything else on the system reading the newer interface sees stale numbers. And once the deprecated path is actually removed, TDP control stops working.
The newer interface looks like a drop-in target. All three attributes are there,
current_valueis writable (0644), and each one exposes bounds so they don't need hardcoding:One naming gotcha:
ppt_fppton the old path maps toppt_pl3_fppton the new one.Is this already on your radar? Happy to test a branch on a GZ302EA, or put together a PR that prefers
/sys/class/firmware-attributes/asus-armoury/and falls back to the old path when it isn't present.Versions: z13ctl 1.3.2, kernel 7.1.11, asus_wmi BIOS WMI version 9.4.