[Feature request] Use latest syncstorage-rs version

[update-freak]

Hi,

I saw that when I check the version with heartbeat at the end of the syncstorage-URL the version is 0.17.15.
On Github from Mozilla https://github.com/mozilla-services/syncstorage-rs the latest version is 0.18.2.
Is it possible to use that latest version with your installation script?

[dan-r]

There's no version set in the Dockerfile so you just need to build your image again and redeploy. If you used docker-compose do:

docker-compose build --no-cache
docker-compose up -d

[update-freak]

Ok, that's strange that I downloaded the files yesterday and build it today and it's still 0.17.15

I used the command:
docker-compose up
via SSH on my Synology NAS

[0xGingi]

Now that you mention it, fresh install for me also, and I'm on version "0.17.15"

[0xGingi]

Ah, this is why, https://github.com/mozilla-services/syncstorage-rs/blob/e0093a88bfc059a891c1a5d3f74cef068b720861/Cargo.toml#L21

in the Cargo.toml, no one has updated the version number past 0.17.15

I've made a PR to see if they'll fix it: mozilla-services/syncstorage-rs#1666

[update-freak]

Thanks a lot @0xGingi for fixing it :)
I rebuild the image and now the correct (latest) version (0.18.2) is show.
Therefore I will close this issue.

[update-freak]

@0xGingi I saw that the 0.18.3 was released. Is it possible to do the Change also for that version, that the v0.18.3 is displayed?

[0xGingi]

@update-freak Looks like they already bumped the version

mozilla-services/syncstorage-rs#1699

[update-freak]

@0xGingi I re-installed syncstorage again (fresh installation) and get as version "0.18.3", but there is even a v0.20.0. Can you please have a look if it's the same problem as previously?

[mcab]

0.19.0 has upstream use poetry now which fundamentally changes how the Dockerfile should work. Otherwise, it doesn't look like there's many new features or functionality to warrant an upgrade. If your installation works, you should still stick with that.

If you're still curious on upgrading, the diff below should build and run.

diff to 0.20.1

3c3
< ARG GIT_COMMIT=1dc421474df2a4ee973d529534cd0eb7189d58ce
---
> ARG GIT_COMMIT=9f591154c75cb29a205d257f4d41638217b73408 # 0.20.1
11c11
<     python3-virtualenv \
---
>     python3-venv \
24,25c24,42
< # Setup the Python venv
< RUN virtualenv venv \
---
> # Setup Python poetry + venv
> ENV POETRY_HOME="/opt/poetry" \
>     POETRY_VIRTUALENVS_IN_PROJECT=1 \
>     POETRY_NO_INTERACTION=1
> 
> ENV PATH="$POETRY_HOME/bin:$PATH"
> 
> RUN curl -sSL https://install.python-poetry.org | python3 - && \
>     ln -s $POETRY_HOME/bin/poetry /usr/local/bin/poetry && \
>     poetry --version && \
>     poetry config virtualenvs.create false && \
>     poetry self add poetry-plugin-export
> 
> RUN poetry export --no-interaction --without dev --output requirements.txt --without-hashes
> WORKDIR /app/tools/tokenserver \
> RUN poetry export --no-interaction --without dev --output requirements.txt --without-hashes
> WORKDIR /app
> 
> RUN python3 -mvenv venv

[update-freak]

thanks for the info.
Currently also the 0.21.0 is released

[luixxiul]

The diff worked for me to start up the server, but an error A database error occurred: Table 'tokenserver_rs.services' doesn't exist keeps occuring.

INFO	Server-reported error: {"location":"internal","name":"","description":"A database error occurred: Table 'tokenserver_rs.services' doesn't exist"}

→ Fixed by correcting the path to directories for migration