Incorrect Speedtest Unit Conversion

[willshen]

Describe the bug
Looks like the speedtest library used returns speed in Megabit per second, but the exporter assumed it was given megabytes per second when converting to bytes per second .

Expected behavior
Seems like the metric name should either be download_speed_bps (lower case b to indicate bits per second) or that the conversion should include a divide by 8 to convert the speedtest result, which is bits per second, to bytes per second (since the metric name is Bps).

[genofire]

Looks for me, like something get miss over prometheus -> the metric-names are uppercase (bytes), so it looks correct.

# HELP speedtest_download_speed_Bps Last download speedtest result
# TYPE speedtest_download_speed_Bps gauge
speedtest_download_speed_Bps{} 1.61xxx
# HELP speedtest_latency_seconds Measured latency on last speed test
# TYPE speedtest_latency_seconds gauge
speedtest_latency_seconds{} 0.017xxx
# HELP speedtest_scrape_duration_seconds Time to preform last speed test
# TYPE speedtest_scrape_duration_seconds gauge
speedtest_scrape_duration_seconds{} x.xxx
# HELP speedtest_up Was the last speedtest successful.
# TYPE speedtest_up gauge
speedtest_up{test_uuid="xxxxxxx-xxx-xxxx-xxxxx"} 1
# HELP speedtest_upload_speed_Bps Last upload speedtest result
# TYPE speedtest_upload_speed_Bps gauge
speedtest_upload_speed_Bps{} 1.xxxx

but it should be improve the description, to see this error.

A breaking change in dashboard would be to rename the metric-name to long name like:
speedtest_download_speed_bytes_per_sec or speedtest_rx_bytes_per_sec