From dfb3b014377329fd1f39c15b5333dd4ab167f3e5 Mon Sep 17 00:00:00 2001 From: Kevin Moore Date: Fri, 23 Oct 2026 21:50:17 +0000 Subject: [PATCH 1/2] [cli_util, process] Fix new lints and platform deprecations - Update `pkgs/cli_util` to call `doneCompleter.complete()` without redundant `null` arguments and ignore `avoid_redundant_argument_values` on `maxVisibleItems: 5` in `select_dialog_test.dart` for Dart `3.15.0-dev`. - Ignore `deprecated_member_use` in `pkgs/process` (`common.dart` and `common_test.dart`) for `package:platform` `3.2.0` deprecations and bump `process` to `5.0.7-wip`. --- pkgs/cli_util/lib/src/components/select_dialog.dart | 4 ++-- pkgs/cli_util/test/select_dialog_test.dart | 2 +- pkgs/process/CHANGELOG.md | 2 ++ pkgs/process/lib/src/interface/common.dart | 2 ++ pkgs/process/pubspec.yaml | 2 +- pkgs/process/test/src/interface/common_test.dart | 2 ++ 6 files changed, 10 insertions(+), 4 deletions(-) diff --git a/pkgs/cli_util/lib/src/components/select_dialog.dart b/pkgs/cli_util/lib/src/components/select_dialog.dart index 95d60e9d22..2734ad2d6b 100644 --- a/pkgs/cli_util/lib/src/components/select_dialog.dart +++ b/pkgs/cli_util/lib/src/components/select_dialog.dart @@ -179,7 +179,7 @@ Future?> _runDialog( // Handle Ctrl+C and abort the dialog. final sigintSub = ProcessSignal.sigint.watch().listen((_) { if (!doneCompleter.isCompleted) { - doneCompleter.complete(null); + doneCompleter.complete(); } }); cleanupTasks.add(sigintSub.cancel); @@ -236,7 +236,7 @@ Future?> _runDialog( doneCompleter.complete(selectedIndices); return; case Key.quit: - doneCompleter.complete(null); + doneCompleter.complete(); return; } diff --git a/pkgs/cli_util/test/select_dialog_test.dart b/pkgs/cli_util/test/select_dialog_test.dart index cb3fca6341..604d1302f4 100644 --- a/pkgs/cli_util/test/select_dialog_test.dart +++ b/pkgs/cli_util/test/select_dialog_test.dart @@ -446,7 +446,7 @@ ${maybeLegend()}'''); final future = renderer( options, inputController.stream, - maxVisibleItems: 5, + maxVisibleItems: 5, // ignore: avoid_redundant_argument_values ); await pumpEventQueue(); diff --git a/pkgs/process/CHANGELOG.md b/pkgs/process/CHANGELOG.md index 45cffaab12..6160302f67 100644 --- a/pkgs/process/CHANGELOG.md +++ b/pkgs/process/CHANGELOG.md @@ -1,3 +1,5 @@ +## 5.0.7-wip + ## 5.0.6 * Add an example app. diff --git a/pkgs/process/lib/src/interface/common.dart b/pkgs/process/lib/src/interface/common.dart index df5101c6ff..80801abf01 100644 --- a/pkgs/process/lib/src/interface/common.dart +++ b/pkgs/process/lib/src/interface/common.dart @@ -2,6 +2,8 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. +// ignore_for_file: deprecated_member_use + import 'package:file/file.dart'; import 'package:file/local.dart'; import 'package:path/path.dart' show Context; diff --git a/pkgs/process/pubspec.yaml b/pkgs/process/pubspec.yaml index 432a15904d..0df5ffdcac 100644 --- a/pkgs/process/pubspec.yaml +++ b/pkgs/process/pubspec.yaml @@ -1,6 +1,6 @@ name: process description: A pluggable, mockable process invocation abstraction for Dart. -version: 5.0.6 +version: 5.0.7-wip repository: https://github.com/dart-lang/tools/tree/main/pkgs/process issue_tracker: https://github.com/dart-lang/tools/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Aprocess diff --git a/pkgs/process/test/src/interface/common_test.dart b/pkgs/process/test/src/interface/common_test.dart index 71bed11277..353486c214 100644 --- a/pkgs/process/test/src/interface/common_test.dart +++ b/pkgs/process/test/src/interface/common_test.dart @@ -2,6 +2,8 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. +// ignore_for_file: deprecated_member_use + import 'dart:io' as io; import 'package:file/file.dart'; From 2326d764a2dd556b23b2b075d838c60adc05d332 Mon Sep 17 00:00:00 2001 From: Kevin Moore Date: Fri, 23 Oct 2026 23:40:43 +0000 Subject: [PATCH 2/2] [cli_util] Remove avoid_redundant_argument_values from analysis_options.yaml - Drop `avoid_redundant_argument_values` from `pkgs/cli_util/analysis_options.yaml` and remove the `// ignore: avoid_redundant_argument_values` comments in `pkgs/cli_util/test/select_dialog_test.dart`. --- pkgs/cli_util/analysis_options.yaml | 1 - pkgs/cli_util/test/select_dialog_test.dart | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/pkgs/cli_util/analysis_options.yaml b/pkgs/cli_util/analysis_options.yaml index a30462edeb..ee61822b6b 100644 --- a/pkgs/cli_util/analysis_options.yaml +++ b/pkgs/cli_util/analysis_options.yaml @@ -12,7 +12,6 @@ linter: - avoid_bool_literals_in_conditional_expressions - avoid_classes_with_only_static_members - avoid_private_typedef_functions - - avoid_redundant_argument_values - avoid_returning_this - avoid_unused_constructor_parameters - avoid_void_async diff --git a/pkgs/cli_util/test/select_dialog_test.dart b/pkgs/cli_util/test/select_dialog_test.dart index 604d1302f4..50d2307cc1 100644 --- a/pkgs/cli_util/test/select_dialog_test.dart +++ b/pkgs/cli_util/test/select_dialog_test.dart @@ -292,7 +292,7 @@ ${maybeLegend()}'''); final future = renderer( ['a', 'b', 'c', 'd', 'e', 'f', 'g'], inputController.stream, - maxVisibleItems: 5, // ignore: avoid_redundant_argument_values + maxVisibleItems: 5, ); await pumpEventQueue(); @@ -335,7 +335,7 @@ ${maybeLegend()}'''); final future = renderer( options, inputController.stream, - maxVisibleItems: 5, // ignore: avoid_redundant_argument_values + maxVisibleItems: 5, ); await pumpEventQueue(); @@ -446,7 +446,7 @@ ${maybeLegend()}'''); final future = renderer( options, inputController.stream, - maxVisibleItems: 5, // ignore: avoid_redundant_argument_values + maxVisibleItems: 5, ); await pumpEventQueue();