From fa0e1fe2e691ad6ec5ac1d100fab568cd4a812bc Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Tue, 10 Nov 2026 17:39:05 +0200 Subject: [PATCH 1/4] [csslib] Recognize the rebeccapurple color keyword --- pkgs/csslib/CHANGELOG.md | 1 + pkgs/csslib/lib/src/token_kind.dart | 1 + pkgs/csslib/test/color_keyword_test.dart | 15 +++++++++++++++ 3 files changed, 17 insertions(+) create mode 100644 pkgs/csslib/test/color_keyword_test.dart diff --git a/pkgs/csslib/CHANGELOG.md b/pkgs/csslib/CHANGELOG.md index 2b5e3472da..17d86ec7c9 100644 --- a/pkgs/csslib/CHANGELOG.md +++ b/pkgs/csslib/CHANGELOG.md @@ -1,5 +1,6 @@ ## 1.0.3-wip +- Recognize the `rebeccapurple` color keyword. - Fix the values of the `aliceblue` color keyword and the `Color.aliceBlue`, `Color.antiqueWhite` and `Color.peru` constants. - Fix unhandled exceptions (`RangeError`, `FormatException`, `StateError`, diff --git a/pkgs/csslib/lib/src/token_kind.dart b/pkgs/csslib/lib/src/token_kind.dart index 754d661fc7..cf5c60086e 100644 --- a/pkgs/csslib/lib/src/token_kind.dart +++ b/pkgs/csslib/lib/src/token_kind.dart @@ -421,6 +421,7 @@ class TokenKind { {'name': 'plum', 'value': 0xDDA0DD}, {'name': 'powderblue', 'value': 0xB0E0E6}, {'name': 'purple', 'value': 0x800080}, + {'name': 'rebeccapurple', 'value': 0x663399}, {'name': 'red', 'value': 0xFF0000}, {'name': 'rosybrown', 'value': 0xBC8F8F}, {'name': 'royalblue', 'value': 0x4169E1}, diff --git a/pkgs/csslib/test/color_keyword_test.dart b/pkgs/csslib/test/color_keyword_test.dart new file mode 100644 index 0000000000..b24dc45454 --- /dev/null +++ b/pkgs/csslib/test/color_keyword_test.dart @@ -0,0 +1,15 @@ +// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file +// for details. All rights reserved. Use of this source code is governed by a +// BSD-style license that can be found in the LICENSE file. + +import 'package:csslib/parser.dart'; +import 'package:test/test.dart'; + +void main() { + test('rebeccapurple is a named color', () { + expect(TokenKind.colorValue(TokenKind.matchColorName('rebeccapurple')!), + 0x663399); + expect(TokenKind.colorValue(TokenKind.matchColorName('RebeccaPurple')!), + 0x663399); + }); +} From 3a3569d7891a1a8265e4211f21ce1588a39f10cf Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Tue, 10 Nov 2026 19:31:41 +0200 Subject: [PATCH 2/4] Add Color.rebeccaPurple --- pkgs/csslib/lib/src/property.dart | 1 + pkgs/csslib/test/color_keyword_test.dart | 1 + 2 files changed, 2 insertions(+) diff --git a/pkgs/csslib/lib/src/property.dart b/pkgs/csslib/lib/src/property.dart index 0188c2b8e2..fe775c65d3 100644 --- a/pkgs/csslib/lib/src/property.dart +++ b/pkgs/csslib/lib/src/property.dart @@ -454,6 +454,7 @@ class Color implements _StyleProperty, ColorBase { static final Color plum = const Color.hex('dda0dd'); static final Color powderBlue = const Color.hex('b0e0e6'); static final Color purple = const Color.hex('800080'); + static final Color rebeccaPurple = const Color.hex('663399'); static final Color red = const Color.hex('ff0000'); static final Color rosyBrown = const Color.hex('bc8f8f'); static final Color royalBlue = const Color.hex('4169e1'); diff --git a/pkgs/csslib/test/color_keyword_test.dart b/pkgs/csslib/test/color_keyword_test.dart index b24dc45454..8729b8dae4 100644 --- a/pkgs/csslib/test/color_keyword_test.dart +++ b/pkgs/csslib/test/color_keyword_test.dart @@ -11,5 +11,6 @@ void main() { 0x663399); expect(TokenKind.colorValue(TokenKind.matchColorName('RebeccaPurple')!), 0x663399); + expect(Color.rebeccaPurple.argbValue, 0x663399); }); } From d11dcaafdf960fe234b58605c8217bbb2b61c315 Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Tue, 10 Nov 2026 19:36:17 +0200 Subject: [PATCH 3/4] Update the changelog for the review fix --- pkgs/csslib/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/csslib/CHANGELOG.md b/pkgs/csslib/CHANGELOG.md index 17d86ec7c9..aac37a3f79 100644 --- a/pkgs/csslib/CHANGELOG.md +++ b/pkgs/csslib/CHANGELOG.md @@ -1,6 +1,6 @@ ## 1.0.3-wip -- Recognize the `rebeccapurple` color keyword. +- Recognize the `rebeccapurple` color keyword and add `Color.rebeccaPurple`. - Fix the values of the `aliceblue` color keyword and the `Color.aliceBlue`, `Color.antiqueWhite` and `Color.peru` constants. - Fix unhandled exceptions (`RangeError`, `FormatException`, `StateError`, From 4917afa47845a2909726d63e955ee96becade4fb Mon Sep 17 00:00:00 2001 From: palmoni5 Date: Sat, 14 Nov 2026 18:40:12 +0200 Subject: [PATCH 4/4] Address review feedback --- pkgs/csslib/CHANGELOG.md | 2 +- pkgs/csslib/lib/src/property.dart | 1 - pkgs/csslib/test/color_keyword_test.dart | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/csslib/CHANGELOG.md b/pkgs/csslib/CHANGELOG.md index aac37a3f79..17d86ec7c9 100644 --- a/pkgs/csslib/CHANGELOG.md +++ b/pkgs/csslib/CHANGELOG.md @@ -1,6 +1,6 @@ ## 1.0.3-wip -- Recognize the `rebeccapurple` color keyword and add `Color.rebeccaPurple`. +- Recognize the `rebeccapurple` color keyword. - Fix the values of the `aliceblue` color keyword and the `Color.aliceBlue`, `Color.antiqueWhite` and `Color.peru` constants. - Fix unhandled exceptions (`RangeError`, `FormatException`, `StateError`, diff --git a/pkgs/csslib/lib/src/property.dart b/pkgs/csslib/lib/src/property.dart index fe775c65d3..0188c2b8e2 100644 --- a/pkgs/csslib/lib/src/property.dart +++ b/pkgs/csslib/lib/src/property.dart @@ -454,7 +454,6 @@ class Color implements _StyleProperty, ColorBase { static final Color plum = const Color.hex('dda0dd'); static final Color powderBlue = const Color.hex('b0e0e6'); static final Color purple = const Color.hex('800080'); - static final Color rebeccaPurple = const Color.hex('663399'); static final Color red = const Color.hex('ff0000'); static final Color rosyBrown = const Color.hex('bc8f8f'); static final Color royalBlue = const Color.hex('4169e1'); diff --git a/pkgs/csslib/test/color_keyword_test.dart b/pkgs/csslib/test/color_keyword_test.dart index 8729b8dae4..b24dc45454 100644 --- a/pkgs/csslib/test/color_keyword_test.dart +++ b/pkgs/csslib/test/color_keyword_test.dart @@ -11,6 +11,5 @@ void main() { 0x663399); expect(TokenKind.colorValue(TokenKind.matchColorName('RebeccaPurple')!), 0x663399); - expect(Color.rebeccaPurple.argbValue, 0x663399); }); }