Clean up deprecated Prometheus metrics (#9249)

Author: crusaderky

distributed/http/worker/prometheus/core.py

@@ -52,15 +52,6 @@ def collect(self) -> Iterator[Metric]:
                 tasks.add_metric([state], n)
         yield tasks
 
-        yield GaugeMetricFamily(
-            self.build_name("concurrent_fetch_requests"),
-            (
-                "Deprecated: This metric has been renamed to transfer_incoming_count.\n"
-                "Number of open fetch requests to other workers"
-            ),
-            value=ws.transfer_incoming_count,
-        )
-
         if self.server.monitor.monitor_gil_contention:
             yield CounterMetricFamily(
                 self.build_name("gil_contention"),

distributed/http/worker/tests/test_worker_http.py

@@ -35,7 +35,6 @@ async def test_prometheus(c, s, a):
         a.http_server.port, prefix="dask_worker_"
     )
     expected_metrics = {
-        "dask_worker_concurrent_fetch_requests",
         "dask_worker_latency_seconds",
         "dask_worker_memory_bytes",
         "dask_worker_spill_bytes_total",

docs/source/prometheus.rst

@@ -191,9 +191,6 @@ dask_worker_transfer_outgoing_count
     Number of open data transfers to other workers
 dask_worker_transfer_outgoing_count_total
     Total number of data transfers to other workers since the worker was started
-dask_worker_concurrent_fetch_requests
-    **Deprecated:** This metric has been renamed to
-    ``dask_worker_transfer_incoming_count``.
 dask_worker_tick_count_total
     Total number of ticks observed since the server started
 dask_worker_tick_duration_maximum_seconds