Skip to content

Some Suggestions #1

@TSKGHS17

Description

@TSKGHS17

Hi there, 👋
First of all, thank you for your hard work on this project. I have been exploring the code and found it very useful. However, I have a few suggestions that I believe could improve the usability and robustness of the project:

  • Improvements to XML Parsing: In hierarchy.py, the get_current_hierarchy function could benefit from using lxml.etree for XML parsing. This would support multi-byte encodings such as GBK for Chinese in the XML. Additionally, the current version lacks error handling for XML parsing errors.
  • On line 12 of my_gpt.py, it seems the code is unnecessary including the OpenAI organization.
  • Adding a requirements.txt would be highly beneficial.
    Hope these suggestions prove useful. 😊

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions